Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUI for custom elliptical pipes #1

Closed
cbuahin opened this issue Oct 13, 2023 · 2 comments
Closed

Update GUI for custom elliptical pipes #1

cbuahin opened this issue Oct 13, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cbuahin
Copy link
Collaborator

cbuahin commented Oct 13, 2023

GUI should only either accept rise or span. The other can be calculated use S/R factors.

This issue is related to [this one] (USEPA/Stormwater-Management-Model#144) raised by @LRossman

@cbuahin cbuahin self-assigned this Oct 13, 2023
@cbuahin cbuahin added the enhancement New feature or request label Jan 9, 2024
@cbuahin cbuahin added this to the v5.2.5 milestone Jan 10, 2024
cbuahin added a commit that referenced this issue Jan 10, 2024
cbuahin added a commit that referenced this issue Jan 11, 2024
This reverts commit 10fab23.
@cbuahin
Copy link
Collaborator Author

cbuahin commented Jan 11, 2024

Leave it up to users to specify rise and span correctly.

@cbuahin cbuahin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@cbuahin cbuahin reopened this Jan 11, 2024
@cbuahin
Copy link
Collaborator Author

cbuahin commented Jan 13, 2024

I set up a quick experiment using a 100ft pipe with 10ft sub-sections and slopes of 1% and 5% to see the impact of using the constant S/R ratio of 1.56 versus the correct ratio on depth and velocities given the same flows. The results showed some differences. There were larger deviations for the smaller pipes than for the larger pipes as one would expect.

image

Also, the deviations tended to be larger when depths approached the crowns of the pipes, which is also to be expected. Finally, the vertical ellipses showed larger deviations in depth than the horizontal ellipses as changes in flow lead to relatively larger changes in depth.

image

In light of these differences, it makes sense to me to keep the status-quo. Users have the option of selecting one of the standard sizes or they could prescribe their own rise and span values which will lead to more accurate and precise calculations.

@cbuahin cbuahin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant