-
Notifications
You must be signed in to change notification settings - Fork 77
Metric spaces / real analysis #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If I understood the logic
I'm starting to think I got a few names wrong in the Similarly, |
Going further, I think we'd like |
This is sort of it, yes, but the convention is not consistent across the library, so it is easy to confuse different readings, which I also do from time to time. To give you an example, the entry |
Usually, I try to think what a concept is most naturally understood to be. When it comes to cauchy approximations, I might not think of them first and foremost as elements of a new metric space. Rather, they are approximations in a given metric space. Therefore, |
ok. I won't start any mass-renaming; I'm glad I asked. At some point soon I'll need the "metric space of isometries between metric spaces" and things like that, e.g. in #1398. Should it be called |
I would be tempted to distinguish between these things by actually using the word |
I understand it's a subtle distinction. For example when I think of a sequence in a partially ordered set, I don't immediately think of them as a partially ordered set, but as sequences in the underlying type. So, in this mindset, |
ok. I was thinking I should rename the module like this but I'm still not sure about the name. I have a few more PRs on the way before I really need to go there but I'll give it more thoughts. |
This suggestion seems sound to me |
For sequences, though, I think the situation is a bit different. I wouldn't interpret |
mmh. we just merged #1388 with the names If I understand correctly, one key difference between |
This PR fixes some naming issues raised in #1401 (comment) and https://github.com/UniMath/agda-unimath/pull/1388/files#r2054971412. It introduces the following changes: - `type-sequence-Preorder` and `type-sequence-Poset` are now `sequence-type-Preorder` and `sequence-type-Poset`, since they're actually `sequence (type-XX ..)`; - on the other hand, `type-increasing-sequence-Poset` is now called `increasing-sequence-Poset` since it actively uses the poset structure (like `isometry-Metric-Space` uses the metric structure). The corresponding poset is now called `poset-increasing-sequence-Poset`.
This aims at centralizing conversations regarding metric spaces and real / functional analysis.
Concepts
Results
Related Issues
Related Pull requests
The text was updated successfully, but these errors were encountered: