-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I intergrate/submit my own upscaler to be apart of gamescope? #788
Comments
You can just pull request it, see how FSR and NIS are implemented in Gamescope. Please also provide comparisons. |
Comparisons between native and LS1 or LS1 to other upscalers such as FSR 1? I can do both |
Will LS1 need a license to use?? Maybe implement Anime4K?? |
Anime4k would not be a great fit for Steam Deck / Gamescope, due the purpose of the upscaler and the purpose of this service. LS1 will not need a license to use, if it is added it will be free and avalible to everyone to benefit from. LS1 already has better results than FSR 1 in a lot of areas and unlike FSR 1 which is abandoned since FSR 2 released LS1 is continuously being updated and improved, and that vision will remain true until we hit the physical limitations of what a spatial upscaler can achieve and there is no more room to improve on it, so we really hope it is considered being added, as I'd be willing to give the source code. |
Can LS1 outperform FSR in terms of performance? |
I have used ls1 on windows and I find I can lower the res a bit more while keeping quality with it compared to FSR 1 I would love to be able to use the upscaler on my steam deck and I hope you consider it, if it’s possible to integrate it |
@KingOwnageXV apologies for the ping, but has there been any update on adding your upscaler to gamescope? Having this option (and perhaps someone making it configurable via a Decky Plugin afterward) would be a HUGE benefit to the deck community. Personally I’d even pay for your regular software for even newer versions of your excellent upscaler. I can only afford a steam deck so getting even more performance out of it would mean the world to me and others. Any info appreciated :) keep up the great work! |
Hmm So it would theoretically be possible to use LS1 w/ gamescope if LS1 was ported to using the reshade @kangurek-kao does LS1 do upscaling, or does it only do sharpening? |
@sharkautarch It does both upscaling (custom scaling algorithm) and sharpening (five levels, from 0 to 4). It should use compute shaders, as the software of origin (Lossless Scaling) works via hooking up to Windows APIs (DXGI, WGC, GDI) and injecting itself at the very end of window rendering pipeline (thus the requirement of running software in windowed mode). There's also a LS1 Performance model, which is 40% more efficient than LS1, but at cost of being less precise and more prone to ringing and oversharpening. This is noticeable especially at higher resolutions (e.g. 1440p -> 2160p) Edit: Typos |
Hmmm Tho I think you may still need to do some editing yourself, because you'd ideally have your shaders take a sampler2d texture that acts as the shader's input image, and an image2D texture that acts as the output The binding number that's specified in the shader is also the same numbering used when binding resources and/or images to the vulkan pipeline: gamescope/src/rendervulkan.cpp Line 742 in a215a8d
gamescope/src/rendervulkan.cpp Line 1436 in a215a8d
(Specifically the number assigned to .dstBinding for VkWriteDescriptorSet, and the number assigned to .binding for VkDescriptorSetLayoutBinding)Yes, it is pretty tedious and complicated... Feel free to ask for help if you have any questions |
You can just compile HLSL with glslangValidator or any of the other things with minor alterations fwiw |
Eagerly waiting to have this implemented in Gamescope, as this seems to be the only way to have Lossless Scaling in Linux |
Only If they have any questions, they can always ask here |
FYI I'm only responsible for PL translations via Crowdin. I have no access to the source code and I guess that @KingOwnageXV might be the one that would be responsible for shader prep. |
@kangurek-kao My bad on that point |
Anyone know of any progress on this? Would love another upscaler on my deck! A decky plug-in would be incredible but even a less convenient way I’d still try. |
@KingOwnageXV Any luck with this? |
@KingOwnageXV Would love to see this implemented for steam deck, we need frame generation. |
Hello, I was wondering if their is an official process to get your own upscaler intergrated into gamescope - I am a co-creator of the program "Lossless Scaling" which you can find here: https://store.steampowered.com/app/993090
We have been working on our own lightweight spatial upscaler to compete with FSR 1 and in many ways it exceeds it in quality to some degree. It's called "LS1" and I am willing to share the source code with gamescope if they are willing to at least look at it for potential integration. It works great on APUs and provides excellent upscaling quality and theirs even a more light performance version of it too.
If I'm not in the right place to request this please direct me where or give me some contact information, as this is currently the best spatial upscaler to date. I am also willing to provide a free license key of the software with any gamescope dev if they are interested, thank you for your time
The text was updated successfully, but these errors were encountered: