Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not detecting jump tables correctly #5715

Open
samrussell opened this issue Jul 10, 2024 · 0 comments
Open

Not detecting jump tables correctly #5715

samrussell opened this issue Jul 10, 2024 · 0 comments

Comments

@samrussell
Copy link
Contributor

Version and Platform (required):

  • Binary Ninja Version: [e.g. 4.0.5336]
  • OS: Windows
  • OS Version: 10
  • CPU Architecture: x64

Bug Description:
Jump table not detected on sample prog1.vmp.exe avast/retdec#1155
prog1.vmp.exe.zip

image

Steps To Reproduce:
Open sample and go to 0x1401b203f

Expected Behavior:
(after manually adding ranges):

image

Additional notes

Manually adding user defined ranges as per https://www.lodsb.com/reversing-complex-jumptables-in-binary-ninja resolves the problem so I assume this is an edge case in jump table detection. At this line:

 148 @ 1401af09e  rcx_1 = [&data_1401b0456 + (rax << 3)].q

rax is correctly detected as being an unsigned range from 0:0x100 but rcx_1 is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samrussell