test: fix test for 2 single tables

Author: WatheqAlshowaiter

src/BackupTablesService.php

@@ -110,10 +110,8 @@ protected function backupTablesForSqlite($newTableName, $table)
         ];
     }
 
-    protected function backupTablesForForMysqlAndMariaDb($newTableName, $table): array
+        protected function backupTablesForForMysqlAndMariaDb($newTableName, $table)
     {
-        logger('mariadb');
-
         DB::statement(/**@lang MySQL*/ "CREATE TABLE $newTableName AS SELECT * FROM $table");
 
         $newCreatedTables[] = $newTableName;

tests/BackupTablesTest.php

@@ -78,8 +78,8 @@ public function test_generate_single_table_backup_all_table_data()
     public function test_generate_2_single_table_backup_all_table_data()
     {
         Carbon::setTestNow();
-        $tableName = 'fathers';
-        $tableName2 = 'sons';
+        $table1 = 'fathers';
+        $table2 = 'sons';
 
         Father::create([
             'id' => 1,
@@ -92,31 +92,22 @@ public function test_generate_2_single_table_backup_all_table_data()
             'father_id' => 1,
         ]);
 
-        BackupTables::backupTables($tableName);
+        BackupTables::backupTables($table1);
 
-        $newTableName = $tableName.'_backup_'.now()->format('Y_m_d_H_i_s');
-        $newTableName2 = $tableName2 . '_backup_' . now()->format('Y_m_d_H_i_s');
+        $currentDateTime = now()->format('Y_m_d_H_i_s');
+        $newTableName =  $table1 . '_backup_' . $currentDateTime;
+        $newTableName2 = $table2 . '_backup_' . $currentDateTime;
 
         $this->assertTrue(Schema::hasTable($newTableName));
 
+        // Verify data in fathers_backup table
+        $this->assertEquals(DB::table('fathers')->value('first_name'), DB::table($newTableName)->value('first_name'));
+        $this->assertEquals(DB::table('fathers')->value('email'), DB::table($newTableName)->value('email'));
 
-        //if (DB::getDriverName() == 'mysql') { // todo debugging
-        //    dump(Father::first()->first_name);
-        //}
-
-        $this->assertEquals(DB::table($tableName)->value('first_name'), DB::table($newTableName)->value('first_name'));
-        $this->assertEquals(DB::table($tableName)->value('email'), DB::table($newTableName)->value('email'));
-
-        if (DB::getDriverName() == 'mysql' || DB::getDriverName() == 'mariadb' || (float) App::version() >= Constants::VERSION_AFTER_STORED_AS_VIRTUAL_AS_SUPPORT) {
-            $this->assertEquals(DB::table($tableName)->value('full_name'), DB::table($newTableName)->value('full_name')); // StoredAs tables
-            //$this->assertEquals(DB::table($tableName)->value('status'), DB::table($newTableName)->value('status')); // virtualAs tables
-        }
-
-        BackupTables::backupTables($tableName2);
+        // Verify data in sons_backup table
+        BackupTables::backupTables($table2);
         $this->assertTrue(Schema::hasTable($newTableName2));
-
-        $this->assertEquals(DB::table($tableName2)->value('father_id'), DB::table($newTableName2)->value('father_id')); // foreign key
-
+        $this->assertEquals(DB::table('sons')->value('father_id'), DB::table($newTableName2)->value('father_id'));
     }
 
     public function test_generate_multiple_table_backup()