refactor: improve console command

Author: WatheqAlshowaiter

README.md

@@ -10,7 +10,8 @@
 
 Backup single or multiple database tables with ease.
 
-> Note: if you want a full database backup with many features go for [Spatie Laravel Backup](https://github.com/spatie/laravel-backup).
+> [!NOTE]
+> If you want a full database backup with many features, go for [Spatie Laravel Backup](https://github.com/spatie/laravel-backup).
 
 ## Installation
 
@@ -27,7 +28,7 @@ generate `$tableToBackup_backup_2024_08_22_17_40_01` table in the database with
 the datetime `2024_08_22_17_40_01` will be varied based on your datetime.
 
 You can also use the `php artisan backup:tables <targets>` command to back up tables,
-where `<targets>` is a space-separated list of tables names or models.
+where `<targets>` is a space-separated list of table names or models.
 
 ```php
 use WatheqAlshowaiter\BackupTables\BackupTables; // import the facade
@@ -45,7 +46,7 @@ class ChangeSomeData
 
 And More Customizations
 
-- You can use an array to backup more than one table
+- You can use an array to back up more than one table
 
 ```php
 BackupTables::generateBackup(['users', 'posts']); 
@@ -68,9 +69,10 @@ BackupTables::generateBackup([User::class, Post::class]); // users_backup_2024_0
 BackupTables::generateBackup('users', 'Y_d_m_H_i'); // users_backup_2024_22_08_17_40
 ```
 
-> *Note: be aware if you customize the datetime to wide datetime the package will check the backup datetime file and
+> [!WARNING]
+> Be aware if you customize the datetime to wide datetime the package will check the backup datetime file and
 > will be skipped
-> the exact same datetime, so most of the time the default will be fine
+> the same datetime, so most of the time the default will be fine
 > For example: if you use this `Y_d_m_H` you can not generate the same backup in the same hour
 
 ```php
@@ -81,19 +83,22 @@ BackupTables::generateBackup('users', 'Y_d_m'); // can not generate the same bac
 - Using the artisan command for one or more tables/models
 ```bash
 php artisan backup:tables users posts # users_backup_2024_08_22_17_40_01, posts_backup_2024_08_22_17_40_01
-php artisan backup:tables \App\Models\User \App\Models\Post # users_backup_2024_08_22_17_40_01, posts_backup_2024_08_22_17_40_01
+php artisan backup:tables \\App\\Models\\User \\App\\Models\\Post # users_backup_2024_08_22_17_40_01, posts_backup_2024_08_22_17_40_01
 ```
 
 ## Why?
 
-Sometimes you want to backup some database tables before changing data for whatever reason, this package serves this
-need. I used it personally before adding foreign keys for tables that required the removal of unlinked fields for parent tables.
-You may find some situation where you play with table data or you're afraid of missing data so you backup these tables
+Sometimes you want to back up some database tables before changing data for whatever reason, this package serves this
+need. 
+
+I used it personally before adding foreign keys to tables that required removing unlinked fields from parent tables.
+
+You may find some situation where you play with table data, or you're afraid of missing data, so you back up these tables
 beforehand.
 
 ## Features
 
-✅ Backup tables from the code or from the console command.
+✅ Backup tables from the code using (Facade) or from the console command.
 
 ✅ Supports Laravel versions: 11, 10, 9, 8, 7, and 6.
 
@@ -113,11 +118,15 @@ composer test
 
 ## Changelog
 
-Please see [CHANGELOG](CHANGELOG.md) for more information on what has changed recently.
+Please see [CHANGELOG](CHANGELOG.md) for more information on recent changes.
 
 ## Contributing
 
-If you have any ideas or suggestions to improve it or fix bugs, your contribution is welcome. I encourage you to look at [todos](./todos.md) which are the most important features that need to be added. If you have something different, submit an issue first to discuss or report a bug, then do a pull request.
+If you have any ideas or suggestions to improve it or fix bugs, your contribution is welcome. 
+
+I encourage you to look at [todos](./todos.md) which are the most important features that need to be added. 
+
+If you have something different, submit an issue first to discuss or report a bug, then do a pull request.
 
 ## Security Vulnerabilities
 

src/BackupTablesService.php

@@ -111,7 +111,7 @@ protected function returnedBackupResponse($newTableName, $table): array
             'newCreatedTables' => "Newly created table: $newTableName",
         ];
 
-        // to prevent duplicating message if you use generateBackup() twice in the same request event for different tables
+        // to prevent a duplicating message if you use generateBackup() twice in the same request event for different tables
         Arr::forget($this->response, '0');
 
         return $result;

src/Commands/BackupTableCommand.php

@@ -16,8 +16,6 @@ public function handle()
     {
         $tables = $this->argument('targets');
 
-        $tables = $this->getMultipleTables($tables);
-
         try {
             $result = BackupTables::generateBackup($tables);
 
@@ -32,18 +30,4 @@ public function handle()
             return CommandCodes::FAILURE;
         }
     }
-
-    /**
-     * @param $table
-     *
-     * @return false|string[]
-     */
-    private function getMultipleTables($table)
-    {
-        $tablesArr = explode(' ', $table);
-
-        return array_filter($tablesArr, function ($item) {
-            return !empty($item);
-        });
-    }
 }

tests/BackupTableCommandTest.php

@@ -26,10 +26,7 @@ public function it_can_backup_a_table()
 
         $backupTablePattern = 'test_table_backup_'.now()->format('Y_m_d_H_i_s');
 
-        $this->assertTrue(
-            Schema::hasTable($backupTablePattern),
-            "Backup table was not created"
-        );
+        $this->assertTrue(Schema::hasTable($backupTablePattern));
     }
 
     /** @test */
@@ -46,10 +43,7 @@ public function it_can_backup_a_table_by_classname()
 
         $backupTablePattern = 'test_table_backup_'.now()->format('Y_m_d_H_i_s');
 
-        $this->assertTrue(
-            Schema::hasTable($backupTablePattern),
-            "Backup table was not created"
-        );
+        $this->assertTrue(Schema::hasTable($backupTablePattern));
     }
 
     /** @test */
@@ -72,16 +66,13 @@ public function it_can_backup_multiple_tables()
             });
         }
 
-        $this->artisan('backup:tables', ['targets' => implode('  ', $tables)])
+        $this->artisan('backup:tables', ['targets' => $tables])
             ->assertSuccessful();
 
         foreach ($tables as $table) {
             $backupTablePattern = $table.'_backup_'.now()->format('Y_m_d_H_i_s');
 
-            $this->assertTrue(
-                Schema::hasTable($backupTablePattern),
-                "Backup table was not created"
-            );
+            $this->assertTrue(Schema::hasTable($backupTablePattern));
         }
 
     }
@@ -91,32 +82,33 @@ public function it_can_backup_multiple_models()
     {
         $models = [Father::class, Mother::class];
 
-        $this->artisan('backup:tables', ['targets' => implode('  ', $models)])
+        $this->artisan('backup:tables', ['targets' => $models])
             ->assertSuccessful();
 
         $backupTablePattern1 = 'fathers_backup_'.now()->format('Y_m_d_H_i_s');
         $backupTablePattern2 = 'mothers_backup_'.now()->format('Y_m_d_H_i_s');
 
-        $this->assertTrue(
-            Schema::hasTable($backupTablePattern1),
-            "Backup table was not created"
-        );
+        $this->assertTrue(Schema::hasTable($backupTablePattern1));
 
-        $this->assertTrue(
-            Schema::hasTable($backupTablePattern2),
-            "Backup table was not created"
-        );
+        $this->assertTrue(Schema::hasTable($backupTablePattern2));
     }
 
     /** @test */
-    public function it_fails_when_any_table_does_not_exist()
+    public function it_fails_when_any_table_does_not_exist_but_saved_corrected_tables()
     {
         Schema::create('existing_table', function ($table) {
             $table->id();
             $table->timestamps();
         });
 
-        $this->artisan('backup:tables', ['targets' => 'existing_table non_existent_table'])
+        $this->artisan('backup:tables', ['targets' => 'existing_table', 'non_existent_table'])
             ->assertSuccessful();
+
+        $backupExistingTablePattern = 'existing_table_backup_'.now()->format('Y_m_d_H_i_s');
+        $backupNonExistingTablePattern = 'non_existent_table_backup_'.now()->format('Y_m_d_H_i_s');
+
+        $this->assertTrue(Schema::hasTable($backupExistingTablePattern));
+
+        $this->assertFalse(Schema::hasTable($backupNonExistingTablePattern));
     }
 }