From 4a968d37323c9382e6320bf4678b07016779fb4f Mon Sep 17 00:00:00 2001 From: Benjamin Staneck Date: Fri, 20 Apr 2018 21:28:51 +0200 Subject: [PATCH 01/82] Update TOC to 80000 --- CHANGELOG.md | 17 ++++++++++++----- WeakAuras/WeakAuras.toc | 2 +- WeakAurasModelPaths/WeakAurasModelPaths.toc | 2 +- WeakAurasOptions/WeakAurasOptions.toc | 2 +- WeakAurasTemplates/WeakAurasTemplates.toc | 2 +- 5 files changed, 16 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e9351f755f..6fbe44eb89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,11 +1,18 @@ # WeakAuras 2 -## [2.5.10](https://github.com/WeakAuras/WeakAuras2/tree/2.5.10) (2018-04-07) +## [2.5.10-3-g905d80f](https://github.com/WeakAuras/WeakAuras2/tree/905d80f6e47ae9176eda459d3305a3bf199da5cb) (2018-04-20) -[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.9...2.5.10) +[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.10...905d80f6e47ae9176eda459d3305a3bf199da5cb) -Infus (2): +Benjamin Staneck (1): -- Add Timewalking Raids to Load conditions -- Fix importing dynamic groups doesn't reset the offset +- Update TOC to 80000 + +Infus (1): + +- Setup fallback state so that it has no duration + +asakawa-k (1): + +- Add key bindings to open/close the options window (#385) diff --git a/WeakAuras/WeakAuras.toc b/WeakAuras/WeakAuras.toc index e44081d9dc..9048f2dae2 100644 --- a/WeakAuras/WeakAuras.toc +++ b/WeakAuras/WeakAuras.toc @@ -1,4 +1,4 @@ -## Interface: 70300 +## Interface: 80000 ## Title: WeakAuras 2 ## Author: Mirrored and the WeakAuras Team ## Version: @project-version@ diff --git a/WeakAurasModelPaths/WeakAurasModelPaths.toc b/WeakAurasModelPaths/WeakAurasModelPaths.toc index 7415419a3a..60e631cc05 100644 --- a/WeakAurasModelPaths/WeakAurasModelPaths.toc +++ b/WeakAurasModelPaths/WeakAurasModelPaths.toc @@ -1,4 +1,4 @@ -## Interface: 70300 +## Interface: 80000 ## Title: WeakAuras Model Paths ## Author: Mirrored and the WeakAuras Team ## Version: @project-version@ diff --git a/WeakAurasOptions/WeakAurasOptions.toc b/WeakAurasOptions/WeakAurasOptions.toc index 70a399ece5..3c3c8fac78 100644 --- a/WeakAurasOptions/WeakAurasOptions.toc +++ b/WeakAurasOptions/WeakAurasOptions.toc @@ -1,4 +1,4 @@ -## Interface: 70300 +## Interface: 80000 ## Title: WeakAuras Options ## Author: Mirrored and the WeakAuras Team ## Version: @project-version@ diff --git a/WeakAurasTemplates/WeakAurasTemplates.toc b/WeakAurasTemplates/WeakAurasTemplates.toc index 6e933660b4..8de607664b 100644 --- a/WeakAurasTemplates/WeakAurasTemplates.toc +++ b/WeakAurasTemplates/WeakAurasTemplates.toc @@ -1,4 +1,4 @@ -## Interface: 70300 +## Interface: 80000 ## Title: WeakAuras Templates ## Author: Infus ## Version: @project-version@ From 14f80eeae4d24ae9cd2a8226c42721e4962e9ee9 Mon Sep 17 00:00:00 2001 From: Benjamin Staneck Date: Fri, 20 Apr 2018 22:25:27 +0200 Subject: [PATCH 02/82] disable HereBeDragons integration for now --- CHANGELOG.md | 7 ++++--- WeakAuras/Prototypes.lua | 22 +++++++++++----------- WeakAuras/WeakAuras.lua | 8 ++++---- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6fbe44eb89..98070c34da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,11 +1,12 @@ # WeakAuras 2 -## [2.5.10-3-g905d80f](https://github.com/WeakAuras/WeakAuras2/tree/905d80f6e47ae9176eda459d3305a3bf199da5cb) (2018-04-20) +## [2.5.10-4-g8700ba2](https://github.com/WeakAuras/WeakAuras2/tree/8700ba23d69a8323035db01df41bf96511f06848) (2018-04-20) -[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.10...905d80f6e47ae9176eda459d3305a3bf199da5cb) +[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.10...8700ba23d69a8323035db01df41bf96511f06848) -Benjamin Staneck (1): +Benjamin Staneck (2): +- disable HereBeDragons integration for now - Update TOC to 80000 Infus (1): diff --git a/WeakAuras/Prototypes.lua b/WeakAuras/Prototypes.lua index 4fe9906388..3b3a5ff473 100644 --- a/WeakAuras/Prototypes.lua +++ b/WeakAuras/Prototypes.lua @@ -21,7 +21,7 @@ function WeakAuras.IsSpellInRange(spellId, unit) return SpellRange.IsSpellInRange(spellId, unit) end -local HBD = LibStub("HereBeDragons-1.0") +-- local HBD = LibStub("HereBeDragons-1.0") local LibRangeCheck = LibStub("LibRangeCheck-2.0") function WeakAuras.GetRange(unit) @@ -843,16 +843,16 @@ WeakAuras.load_prototype = { type = "string", init = "arg" }, - { - name = "zoneId", - display = L["Zone ID"], - type = "string", - init = "arg", - desc = function() - return L["Zone ID List"] .. "\n" .. L["Current Zone ID:"] .. " " .. HBD:GetPlayerZone(); - end, - test = "WeakAuras.CheckNumericIds([[%s]], zoneId)" - }, + -- { + -- name = "zoneId", + -- display = L["Zone ID"], + -- type = "string", + -- init = "arg", + -- desc = function() + -- return L["Zone ID List"] .. "\n" .. L["Current Zone ID:"] .. " " .. HBD:GetPlayerZone(); + -- end, + -- test = "WeakAuras.CheckNumericIds([[%s]], zoneId)" + -- }, { name = "encounterid", display = L["Encounter ID"], diff --git a/WeakAuras/WeakAuras.lua b/WeakAuras/WeakAuras.lua index e8cc5c3e66..77557038fe 100644 --- a/WeakAuras/WeakAuras.lua +++ b/WeakAuras/WeakAuras.lua @@ -36,7 +36,7 @@ function WeakAurasTimers:ScheduleTimerFixed(func, delay, ...) end local LDB = LibStub:GetLibrary("LibDataBroker-1.1") -local HBD = LibStub("HereBeDragons-1.0") +-- local HBD = LibStub("HereBeDragons-1.0") local timer = WeakAurasTimers WeakAuras.timer = timer @@ -1315,7 +1315,7 @@ function WeakAuras.ScanForLoads(self, event, arg1) end local player, realm, spec, role, zone = UnitName("player"), GetRealmName(), GetSpecialization(), UnitGroupRolesAssigned("player"), GetRealZoneText(); - local zoneId = HBD:GetPlayerZone(); + -- local zoneId = HBD:GetPlayerZone(); local _, race = UnitRace("player") local faction = UnitFactionGroup("player") @@ -1439,8 +1439,8 @@ function WeakAuras.ScanForLoads(self, event, arg1) for id, data in pairs(db.displays) do if (data and not data.controlledChildren) then local loadFunc = loadFuncs[id]; - shouldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", incombat, vehicle, vehicleUi, inpetbattle, group, player, realm, class, spec, race, faction, playerLevel, zone, zoneId, encounter_id, size, difficulty, role); - couldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", true, vehicle, vehicleUi, true, group, player, realm, class, spec, race, faction, playerLevel, zone, zoneId, encounter_id, size, difficulty, role); + shouldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", incombat, vehicle, vehicleUi, inpetbattle, group, player, realm, class, spec, race, faction, playerLevel, zone, encounter_id, size, difficulty, role); --zoneId + couldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", true, vehicle, vehicleUi, true, group, player, realm, class, spec, race, faction, playerLevel, zone, encounter_id, size, difficulty, role); -- oneId if(shouldBeLoaded and not loaded[id]) then WeakAuras.LoadDisplay(id); From 5225a91af02e85e55cf96c705a58bc8a476ff503 Mon Sep 17 00:00:00 2001 From: Benjamin Staneck Date: Sat, 21 Apr 2018 04:58:40 +0200 Subject: [PATCH 03/82] the rank return from UnitAura has been removed --- CHANGELOG.md | 7 ++++--- WeakAuras/BuffTrigger.lua | 8 ++++---- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98070c34da..20ef46054a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,11 +1,12 @@ # WeakAuras 2 -## [2.5.10-4-g8700ba2](https://github.com/WeakAuras/WeakAuras2/tree/8700ba23d69a8323035db01df41bf96511f06848) (2018-04-20) +## [2.5.10-5-g7760785](https://github.com/WeakAuras/WeakAuras2/tree/7760785f21388326f68389c197b2c9353ca99647) (2018-04-21) -[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.10...8700ba23d69a8323035db01df41bf96511f06848) +[Full Changelog](https://github.com/WeakAuras/WeakAuras2/compare/2.5.10...7760785f21388326f68389c197b2c9353ca99647) -Benjamin Staneck (2): +Benjamin Staneck (3): +- the rank return from UnitAura has been removed - disable HereBeDragons integration for now - Update TOC to 80000 diff --git a/WeakAuras/BuffTrigger.lua b/WeakAuras/BuffTrigger.lua index e99a91812b..a0fd98d459 100644 --- a/WeakAuras/BuffTrigger.lua +++ b/WeakAuras/BuffTrigger.lua @@ -492,7 +492,7 @@ function WeakAuras.ScanAuras(unit) -- Update scan cache if(aura_scan_cache[unit][filter].up_to_date < index) then -- Query aura data - name, _, icon, count, _, duration, expirationTime, unitCaster, isStealable, _, spellId = UnitAura(unit, index, filter); + name, icon, count, _, duration, expirationTime, unitCaster, isStealable, _, spellId = UnitAura(unit, index, filter); tooltip, debuffClass, tooltipSize = WeakAuras.GetAuraTooltipInfo(unit, index, filter); aura_scan_cache[unit][filter][index] = aura_scan_cache[unit][filter][index] or {}; @@ -588,7 +588,7 @@ function WeakAuras.ScanAuras(unit) for index, checkname in pairs(data.names) do -- Fetch aura data - name, _, icon, count, _, duration, expirationTime, unitCaster, isStealable, _, spellId = UnitAura(unit, checkname, nil, filter); + name, icon, count, _, duration, expirationTime, unitCaster, isStealable, _, spellId = UnitAura(unit, checkname, nil, filter); if (name) then WeakAuras.SetDynamicIconCache(name, spellId, icon); end @@ -960,7 +960,7 @@ do local updateTriggerState = false; for triggernum, data in pairs(triggers) do local filter = data.debuffType..(data.ownOnly and "|PLAYER" or ""); - local name, rank, icon, count, debuffType, duration, expirationTime, unitCaster, isStealable, nameplateShowPersonal, spellId = UnitAura(unit, spellName, nil, filter); + local name, icon, count, debuffType, duration, expirationTime, unitCaster, isStealable, nameplateShowPersonal, spellId = UnitAura(unit, spellName, nil, filter); if(name and (data.spellId == nil or data.spellId == spellId)) then data.GUIDs = data.GUIDs or {}; data.GUIDs[destGUID] = data.GUIDs[destGUID] or {}; @@ -1119,7 +1119,7 @@ do local updateTriggerState = false; for triggernum, data in pairs(triggers) do local filter = data.debuffType..(data.ownOnly and "|PLAYER" or ""); - local name, rank, icon, count, debuffType, duration, expirationTime, unitCaster, isStealable, nameplateShowPersonal, spellId = UnitAura(uid, spellName, nil, filter); + local name, icon, count, debuffType, duration, expirationTime, unitCaster, isStealable, nameplateShowPersonal, spellId = UnitAura(uid, spellName, nil, filter); if(name) then data.GUIDs = data.GUIDs or {}; data.GUIDs[guid] = data.GUIDs[guid] or {}; From 283a78b7fd248606756a626ccc38fc38fc070c96 Mon Sep 17 00:00:00 2001 From: Infus Date: Sat, 21 Apr 2018 15:54:21 +0200 Subject: [PATCH 04/82] Mark disabled HBD with a TODO 8.0 Also readd Player ZoneId Load Condition by mark it as NYI --- WeakAuras/Prototypes.lua | 22 +++++++++++----------- WeakAuras/WeakAuras.lua | 8 ++++---- WeakAuras/embeds.xml | 2 +- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/WeakAuras/Prototypes.lua b/WeakAuras/Prototypes.lua index 3b3a5ff473..01bf1c99d3 100644 --- a/WeakAuras/Prototypes.lua +++ b/WeakAuras/Prototypes.lua @@ -21,7 +21,7 @@ function WeakAuras.IsSpellInRange(spellId, unit) return SpellRange.IsSpellInRange(spellId, unit) end --- local HBD = LibStub("HereBeDragons-1.0") +-- TODO 8.0 local HBD = LibStub("HereBeDragons-1.0") local LibRangeCheck = LibStub("LibRangeCheck-2.0") function WeakAuras.GetRange(unit) @@ -843,16 +843,16 @@ WeakAuras.load_prototype = { type = "string", init = "arg" }, - -- { - -- name = "zoneId", - -- display = L["Zone ID"], - -- type = "string", - -- init = "arg", - -- desc = function() - -- return L["Zone ID List"] .. "\n" .. L["Current Zone ID:"] .. " " .. HBD:GetPlayerZone(); - -- end, - -- test = "WeakAuras.CheckNumericIds([[%s]], zoneId)" - -- }, + { + name = "zoneId", + display = L["Zone ID (NYI)"], + type = "string", + init = "arg", + desc = function() + return L["Zone ID List"] .. "\n" .. L["Current Zone ID:"] .. " "; --TODO 8.0.. HBD:GetPlayerZone(); + end, + test = "WeakAuras.CheckNumericIds([[%s]], zoneId)" + }, { name = "encounterid", display = L["Encounter ID"], diff --git a/WeakAuras/WeakAuras.lua b/WeakAuras/WeakAuras.lua index 77557038fe..8794889d98 100644 --- a/WeakAuras/WeakAuras.lua +++ b/WeakAuras/WeakAuras.lua @@ -36,7 +36,7 @@ function WeakAurasTimers:ScheduleTimerFixed(func, delay, ...) end local LDB = LibStub:GetLibrary("LibDataBroker-1.1") --- local HBD = LibStub("HereBeDragons-1.0") +-- TODO 8.0 local HBD = LibStub("HereBeDragons-1.0") local timer = WeakAurasTimers WeakAuras.timer = timer @@ -1315,7 +1315,7 @@ function WeakAuras.ScanForLoads(self, event, arg1) end local player, realm, spec, role, zone = UnitName("player"), GetRealmName(), GetSpecialization(), UnitGroupRolesAssigned("player"), GetRealZoneText(); - -- local zoneId = HBD:GetPlayerZone(); + local zoneId = nil; -- TODO 8.0 HBD:GetPlayerZone(); local _, race = UnitRace("player") local faction = UnitFactionGroup("player") @@ -1439,8 +1439,8 @@ function WeakAuras.ScanForLoads(self, event, arg1) for id, data in pairs(db.displays) do if (data and not data.controlledChildren) then local loadFunc = loadFuncs[id]; - shouldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", incombat, vehicle, vehicleUi, inpetbattle, group, player, realm, class, spec, race, faction, playerLevel, zone, encounter_id, size, difficulty, role); --zoneId - couldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", true, vehicle, vehicleUi, true, group, player, realm, class, spec, race, faction, playerLevel, zone, encounter_id, size, difficulty, role); -- oneId + shouldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", incombat, vehicle, vehicleUi, inpetbattle, group, player, realm, class, spec, race, faction, playerLevel, zone, zoneId, encounter_id, size, difficulty, role); --zoneId + couldBeLoaded = loadFunc and loadFunc("ScanForLoads_Auras", true, vehicle, vehicleUi, true, group, player, realm, class, spec, race, faction, playerLevel, zone, zoneId, encounter_id, size, difficulty, role); -- oneId if(shouldBeLoaded and not loaded[id]) then WeakAuras.LoadDisplay(id); diff --git a/WeakAuras/embeds.xml b/WeakAuras/embeds.xml index 8c06ef600f..74f5c07479 100644 --- a/WeakAuras/embeds.xml +++ b/WeakAuras/embeds.xml @@ -18,7 +18,7 @@