Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview for integrators #1292

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Preview for integrators #1292

wants to merge 7 commits into from

Conversation

yuli-ferna
Copy link
Contributor

No description provided.

Copy link

XLabs/portal-bridge-ui #1292

Change Summary:

  • Downgraded Wormhole SDK and Wormhole Connect dependencies to stable/older versions
  • Removed several complex and nested dependencies related to SDK modules
  • Simplified package dependencies, potentially reducing overall package complexity

Risk Score: 3/10

  • Explanation: Minor version downgrade with dependency simplification, low potential for breaking changes

Potential Vulnerability:

  • No direct security vulnerabilities identified in the dependency changes

Code Smell:

  • The previous dependency structure included multiple nested SDK modules which added unnecessary complexity
  • Multiple transitive dependencies were removed, suggesting over-engineering in the previous implementation

Debug Log:

  • No debug logs identified in this dependency update

Unintended Consequences:
File: apps/connect/package-lock.json

  • Potential Risk: Version downgrade might remove recent feature improvements or bug fixes
  • Specific Changes:
    "@wormhole-foundation/sdk": "^1.4.0" (downgraded from ^1.7.0)
    "@wormhole-foundation/wormhole-connect": "^1.2.0" (downgraded from ^2.1.0-beta.4-development)
  • May require thorough testing to ensure compatibility with existing codebase

The changes appear to be a deliberate simplification of the project's dependency structure, reducing complexity while potentially trading off some recent feature developments.

@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 15:37 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 15:44 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 15:45 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna changed the title test Preview for integrators Feb 25, 2025
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:09 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet February 25, 2025 16:16 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview February 25, 2025 16:16 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant