Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClearlyDefined not using LicenseRef-scancode-chillicream-1.0 #4085

Open
ariel11 opened this issue Jan 10, 2025 · 3 comments · May be fixed by #4093
Open

ClearlyDefined not using LicenseRef-scancode-chillicream-1.0 #4085

ariel11 opened this issue Jan 10, 2025 · 3 comments · May be fixed by #4093

Comments

@ariel11
Copy link

ariel11 commented Jan 10, 2025

Instead of using the correct LicenseRef-scancode-chillicream-1.0, ClearlyDefined is putting:

  • "Elastic-2.0 AND LicenseRef-scancode-unknown-license-reference," or
  • "Elastic-2.0 AND NOASSERTION."

Unfortunately, these are both wrong. This is not the Elastic-2.0 license, as a key license limitation is missing. The LICENSE file is a match for LicenseRef-scancode-chillicream-1.0.

image

I submitted a curation for v20.0.2, though had to first curate "OTHER" and then edit the yaml file, as the UI was not allowing me to curate a LicenseRef - clearlydefined/curated-data#29191. Will curation support for LicenseRefs be added?

@capfei
Copy link

capfei commented Jan 13, 2025

To add to this, when I run the v32.3.0, the result I get is LicenseRef-scancode-proprietary-license. Here is my scan result.

    -   tool_name: scancode-toolkit
        tool_version: 32.3.0
        options:
            input:
                - scan
            --ignore:
                - result*
            --license: yes
            --license-text: yes
            --yaml: scan/result.yaml
        notice: |
            Generated with ScanCode and provided on an "AS IS" BASIS, WITHOUT WARRANTIES
            OR CONDITIONS OF ANY KIND, either express or implied. No content created from
            ScanCode should be considered or used as legal advice. Consult an Attorney
            for any legal advice.
            ScanCode is a free software code scanning tool from nexB Inc. and others.
            Visit https://github.com/nexB/scancode-toolkit/ for support and download.
        start_timestamp: '2025-01-13T212559.129992'
        end_timestamp: '2025-01-13T212616.571598'
        output_format_version: 4.0.0
        duration: '17.44160532951355'
        message:
        errors: []
        warnings: []
        extra_data:
            system_environment:
                operating_system: win
                cpu_architecture: 64
                platform: Windows-11-10.0.22631-SP0
                platform_version: 10.0.22631
                python_version: 3.12.0 (tags/v3.12.0:0fb18b0, Oct  2 2023, 13:03:39) [MSC v.1935
                    64 bit (AMD64)]
            spdx_license_list_version: '3.25'
            files_count: 2
license_detections:
    -   identifier: proprietary_license-3dd92279-7a49-35f9-125c-d0fe1f2f7ca7
        license_expression: proprietary-license
        license_expression_spdx: LicenseRef-scancode-proprietary-license
        detection_count: 1
        reference_matches:
            -   license_expression: proprietary-license
                license_expression_spdx: LicenseRef-scancode-proprietary-license
                from_file: scan/license.txt
                start_line: 1
                end_line: 89
                matcher: 3-seq
                score: '96.49'
                matched_length: 578
                match_coverage: '96.49'
                rule_relevance: 100
                rule_identifier: proprietary-license_1023.RULE
                rule_url: https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/proprietary-license_1023.RULE
                matched_text: "# ChilliCream License 1.0\r\n\r\nURL: https://chillicream.com/licensing/chillicream-license\r\
                    \n\r\n## Acceptance\r\n\r\nBy using the software, you agree to all of the\
                    \ terms and conditions below.\r\n\r\n## Copyright License\r\n\r\nThe licensor\
                    \ grants you a non-exclusive, royalty-free, worldwide,\r\nnon-sublicensable,\
                    \ non-transferable license to use, copy, distribute, make\r\navailable,\
                    \ and prepare derivative works of the software, in each case subject to\r\
                    \nthe limitations and conditions below.\r\n\r\n## Limitations\r\n\r\nYou\
                    \ may not move, change, disable, or circumvent the license key functionality\r\
                    \nin the software, and you may not remove or obscure any functionality in\
                    \ the\r\nsoftware that is protected by the license key.\r\n\r\nYou may not\
                    \ alter, remove, or obscure any licensing, copyright, or other notices\r\
                    \nof the licensor in the software. Any use of the licensor’s trademarks\
                    \ is subject\r\nto applicable law.\r\n\r\n## Patents\r\n\r\nThe licensor\
                    \ grants you a license, under any patent claims the licensor can\r\nlicense,\
                    \ or becomes able to license, to make, have made, use, sell, offer for\r\
                    \nsale, import and have imported the software, in each case subject to the\r\
                    \nlimitations and conditions in this license. This license does not cover\
                    \ any\r\npatent claims that you cause to be infringed by modifications or\
                    \ additions to\r\nthe software. If you or your company make any written\
                    \ claim that the software\r\ninfringes or contributes to infringement of\
                    \ any patent, your patent license for\r\nthe software granted under these\
                    \ terms ends immediately. If your company makes\r\nsuch a claim, your patent\
                    \ license ends immediately for work on behalf of your\r\ncompany.\r\n\r\n\
                    ## Notices\r\n\r\nYou must ensure that anyone who gets a copy of any part\
                    \ of the software from you\r\nalso gets a copy of these terms.\r\n\r\nIf\
                    \ you modify the software, you must include in any modified copies of the\r\
                    \nsoftware prominent notices stating that you have modified the software.\r\
                    \n\r\n## No Other Rights\r\n\r\nThese terms do not imply any licenses other\
                    \ than those expressly granted in\r\nthese terms.\r\n\r\n## Termination\r\
                    \n\r\nIf you use the software in violation of these terms, such use is not\
                    \ licensed,\r\nand your licenses will automatically terminate. If the licensor\
                    \ provides you\r\nwith a notice of your violation, and you cease all violation\
                    \ of this license no\r\nlater than 30 days after you receive that notice,\
                    \ your licenses will be\r\nreinstated retroactively. However, if you violate\
                    \ these terms after such\r\nreinstatement, any additional violation of these\
                    \ terms will cause your licenses\r\nto terminate automatically and permanently.\r\
                    \n\r\n## No Liability\r\n\r\n_As far as the law allows, the software comes\
                    \ as is, without any warranty or\r\ncondition, and the licensor will not\
                    \ be liable to you for any damages arising\r\nout of these terms or the\
                    \ use or nature of the software, under any kind of\r\nlegal claim._\r\n\r\
                    \n## Definitions\r\n\r\nThe **licensor** is the entity offering these terms,\
                    \ and the **software** is the\r\nsoftware the licensor makes available under\
                    \ these terms, including any portion\r\nof it.\r\n\r\n**you** refers to\
                    \ the individual or entity agreeing to these terms.\r\n\r\n**your company**\
                    \ is any legal entity, sole proprietorship, or other kind of\r\norganization\
                    \ that you work for, plus all organizations that have control over,\r\n\
                    are under the control of, or are under common control with that\r\norganization.\
                    \ **control** means ownership of substantially all the assets of an\r\n\
                    entity, or the power to direct its management and policies by vote, contract,\
                    \ or\r\notherwise. Control can be direct or indirect.\r\n\r\n**your licenses**\
                    \ are all the licenses granted to you for the software under\r\nthese terms.\r\
                    \n\r\n**use** means anything you do with the software requiring one of your\
                    \ licenses.\r\n\r\n**trademark** means trademarks, service marks, and similar\
                    \ rights."
files:
    -   path: scan
        type: directory
        detected_license_expression:
        detected_license_expression_spdx:
        license_detections: []
        license_clues: []
        percentage_of_license_text: '0'
        scan_errors: []
    -   path: scan/license.txt
        type: file
        detected_license_expression: proprietary-license
        detected_license_expression_spdx: LicenseRef-scancode-proprietary-license
        license_detections:
            -   license_expression: proprietary-license
                license_expression_spdx: LicenseRef-scancode-proprietary-license
                matches:
                    -   license_expression: proprietary-license
                        license_expression_spdx: LicenseRef-scancode-proprietary-license
                        from_file: scan/license.txt
                        start_line: 1
                        end_line: 89
                        matcher: 3-seq
                        score: '96.49'
                        matched_length: 578
                        match_coverage: '96.49'
                        rule_relevance: 100
                        rule_identifier: proprietary-license_1023.RULE
                        rule_url: https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/proprietary-license_1023.RULE
                        matched_text: "# ChilliCream License 1.0\r\n\r\nURL: https://chillicream.com/licensing/chillicream-license\r\
                            \n\r\n## Acceptance\r\n\r\nBy using the software, you agree to all\
                            \ of the terms and conditions below.\r\n\r\n## Copyright License\r\
                            \n\r\nThe licensor grants you a non-exclusive, royalty-free, worldwide,\r\
                            \nnon-sublicensable, non-transferable license to use, copy, distribute,\
                            \ make\r\navailable, and prepare derivative works of the software,\
                            \ in each case subject to\r\nthe limitations and conditions below.\r\
                            \n\r\n## Limitations\r\n\r\nYou may not move, change, disable, or\
                            \ circumvent the license key functionality\r\nin the software, and\
                            \ you may not remove or obscure any functionality in the\r\nsoftware\
                            \ that is protected by the license key.\r\n\r\nYou may not alter,\
                            \ remove, or obscure any licensing, copyright, or other notices\r\
                            \nof the licensor in the software. Any use of the licensor’s trademarks\
                            \ is subject\r\nto applicable law.\r\n\r\n## Patents\r\n\r\nThe\
                            \ licensor grants you a license, under any patent claims the licensor\
                            \ can\r\nlicense, or becomes able to license, to make, have made,\
                            \ use, sell, offer for\r\nsale, import and have imported the software,\
                            \ in each case subject to the\r\nlimitations and conditions in this\
                            \ license. This license does not cover any\r\npatent claims that\
                            \ you cause to be infringed by modifications or additions to\r\n\
                            the software. If you or your company make any written claim that\
                            \ the software\r\ninfringes or contributes to infringement of any\
                            \ patent, your patent license for\r\nthe software granted under\
                            \ these terms ends immediately. If your company makes\r\nsuch a\
                            \ claim, your patent license ends immediately for work on behalf\
                            \ of your\r\ncompany.\r\n\r\n## Notices\r\n\r\nYou must ensure that\
                            \ anyone who gets a copy of any part of the software from you\r\n\
                            also gets a copy of these terms.\r\n\r\nIf you modify the software,\
                            \ you must include in any modified copies of the\r\nsoftware prominent\
                            \ notices stating that you have modified the software.\r\n\r\n##\
                            \ No Other Rights\r\n\r\nThese terms do not imply any licenses other\
                            \ than those expressly granted in\r\nthese terms.\r\n\r\n## Termination\r\
                            \n\r\nIf you use the software in violation of these terms, such\
                            \ use is not licensed,\r\nand your licenses will automatically terminate.\
                            \ If the licensor provides you\r\nwith a notice of your violation,\
                            \ and you cease all violation of this license no\r\nlater than 30\
                            \ days after you receive that notice, your licenses will be\r\n\
                            reinstated retroactively. However, if you violate these terms after\
                            \ such\r\nreinstatement, any additional violation of these terms\
                            \ will cause your licenses\r\nto terminate automatically and permanently.\r\
                            \n\r\n## No Liability\r\n\r\n_As far as the law allows, the software\
                            \ comes as is, without any warranty or\r\ncondition, and the licensor\
                            \ will not be liable to you for any damages arising\r\nout of these\
                            \ terms or the use or nature of the software, under any kind of\r\
                            \nlegal claim._\r\n\r\n## Definitions\r\n\r\nThe **licensor** is\
                            \ the entity offering these terms, and the **software** is the\r\
                            \nsoftware the licensor makes available under these terms, including\
                            \ any portion\r\nof it.\r\n\r\n**you** refers to the individual\
                            \ or entity agreeing to these terms.\r\n\r\n**your company** is\
                            \ any legal entity, sole proprietorship, or other kind of\r\norganization\
                            \ that you work for, plus all organizations that have control over,\r\
                            \nare under the control of, or are under common control with that\r\
                            \norganization. **control** means ownership of substantially all\
                            \ the assets of an\r\nentity, or the power to direct its management\
                            \ and policies by vote, contract, or\r\notherwise. Control can be\
                            \ direct or indirect.\r\n\r\n**your licenses** are all the licenses\
                            \ granted to you for the software under\r\nthese terms.\r\n\r\n\
                            **use** means anything you do with the software requiring one of\
                            \ your licenses.\r\n\r\n**trademark** means trademarks, service\
                            \ marks, and similar rights."
                identifier: proprietary_license-3dd92279-7a49-35f9-125c-d0fe1f2f7ca7
        license_clues: []
        percentage_of_license_text: '98.97'
        scan_errors: []
    -   path: scan/scancode-command.txt
        type: file
        detected_license_expression:
        detected_license_expression_spdx:
        license_detections: []
        license_clues: []
        percentage_of_license_text: '0'
        scan_errors: []

@capfei
Copy link

capfei commented Jan 13, 2025

I also noticed the text in https://scancode-licensedb.aboutcode.org/chillicream-1.0.html is missing the text below, even though it is in the license:

# ChilliCream License 1.0

URL: https://chillicream.com/licensing/chillicream-license

## Acceptance

By using the software, you agree to all of the terms and conditions below.

This text is in https://www.nuget.org/packages/BananaCakePop.Middleware/15.0.4/License and https://www.nuget.org/packages/ChilliCream.Nitro.App/20.0.2/License.

AyanSinhaMahapatra added a commit that referenced this issue Jan 14, 2025
Reference: #4085
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra linked a pull request Jan 14, 2025 that will close this issue
6 tasks
@AyanSinhaMahapatra
Copy link
Member

@capfei @ariel11 thanks for the report!

This text was first added at https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/proprietary-license_1023.RULE and then as license shortly afterwards with #3733, but the proprietary rule was never deprecated while adding the license proper, hence this detection bug. This should be fixed with a rule deprecation and a couple of other rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants