From d3529513c895ae58f5e4366f1e2bb13186b91109 Mon Sep 17 00:00:00 2001 From: judovana Date: Fri, 31 Jan 2025 17:26:11 +0100 Subject: [PATCH] warn on false negatives if repro_compare.sh is run after comparable_patch.sh in ReproducibleBuilds.md --- tooling/reproducible/ReproducibleBuilds.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tooling/reproducible/ReproducibleBuilds.md b/tooling/reproducible/ReproducibleBuilds.md index cf5627e40..6eb00e06c 100755 --- a/tooling/reproducible/ReproducibleBuilds.md +++ b/tooling/reproducible/ReproducibleBuilds.md @@ -50,6 +50,8 @@ The patching process involves: - Remove any non-deterministic build process artifact strings, like Manifest Created-By stamps. - Zero out CRC in .gnu_debuglink ELF sections to eliminate .debuginfo-induced differences. +**warning:** If you run `comparable_patch.sh`, do not use `repro_compare.sh` for final comparison. You would get false negatives. Run plain `diff jdk1 jdk2` with any switches you need. + ### How to setup and run comparable_patch.sh on Windows #### Tooling setup: