Same results for similar and identical #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems usefull to have same diff output after both comparable and reproducible builds. This commit is adding PREPROCESS flag to repro_compare.sh. If set to "no", repro_compare.sh. will not run preprocessing, but will just print diff - in same way as when called on reproducible builds.
github-actions
bot
added
the
documentation
|
The label documentation is wrong.... |
andrew-m-leonard
approved these changes
Feb 7, 2025
karianna
approved these changes
Feb 10, 2025
|
Tyvm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When I was following the: d1c15a6, I realised that after the
diff jdk1 jdk2I'm moreover replicating what repro_compare.sh is doing. Thus I thought it would be better to leave it all on repro_compare.sh, and just allow it to skip the whole preprocessing. WDYT?