From 824087f3f862b87c3b338f1a430851606803230b Mon Sep 17 00:00:00 2001 From: Christian_Yemele Date: Mon, 24 Feb 2025 14:19:40 +0100 Subject: [PATCH 1/4] fix(workflow): updated cd --- .github/workflows/CD.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CD.yml b/.github/workflows/CD.yml index 3fda2755..11fd738b 100644 --- a/.github/workflows/CD.yml +++ b/.github/workflows/CD.yml @@ -46,6 +46,10 @@ jobs: docker tag $IMAGE_NAME $IMAGE_ID:$VERSION docker push $IMAGE_ID:$VERSION + # Export the IMAGE_ID and VERSION as environment variables + echo "IMAGE_ID=$IMAGE_ID" >> $GITHUB_ENV + echo "VERSION=$VERSION" >> $GITHUB_ENV + - name: Install kubectl if: github.ref == 'refs/heads/main' # Only run if the branch is main uses: azure/setup-kubectl@v3 @@ -66,4 +70,4 @@ jobs: - name: Update Kubernetes deployment if: github.ref == 'refs/heads/main' # Only run if the branch is main run: | - kubectl set image deployment/mediator-deployment mediator-container=$IMAGE_ID:$VERSION -n ${{ env.NAMESPACE }} + kubectl set image deployment/mediator-deployment mediator-container=${{ env.IMAGE_ID }}:${{ env.VERSION }} -n ${{ env.NAMESPACE }} \ No newline at end of file From e5bf304e38dfbd9c3dc9046df298490b810262a6 Mon Sep 17 00:00:00 2001 From: Christian_Yemele Date: Mon, 24 Feb 2025 14:36:54 +0100 Subject: [PATCH 2/4] fix(): fixing lint code --- .../didcomm-messaging/did-utils/src/methods/peer/util.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs index 03eb7be2..d22f531f 100644 --- a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs +++ b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs @@ -116,7 +116,7 @@ fn are_all_ids_and_references_relative(diddoc: &DIDDocument) -> bool { #[inline] fn check_methods(methods: &Option>, f: impl Fn(&T) -> bool) -> bool { - methods.as_ref().map_or(true, |items| items.iter().all(f)) + methods.as_ref().is_none_or(|items| items.iter().all(f)) } check_methods(&diddoc.verification_method, |method| is_relative(&method.id)) From 7ab9e56ccd203f8b7f35febc4b2720c331857b9f Mon Sep 17 00:00:00 2001 From: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com> Date: Tue, 25 Feb 2025 10:13:08 +0100 Subject: [PATCH 3/4] revert changes --- .../didcomm-messaging/did-utils/src/methods/peer/util.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs index d22f531f..837d4f75 100644 --- a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs +++ b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs @@ -116,7 +116,7 @@ fn are_all_ids_and_references_relative(diddoc: &DIDDocument) -> bool { #[inline] fn check_methods(methods: &Option>, f: impl Fn(&T) -> bool) -> bool { - methods.as_ref().is_none_or(|items| items.iter().all(f)) + methods.as_ref().map_or(true, |items| items.iter().all(f)) } check_methods(&diddoc.verification_method, |method| is_relative(&method.id)) From 1fccfca7ec3120c5084d46d2cab3cac376800043 Mon Sep 17 00:00:00 2001 From: Christian Yemele <144161981+Christiantyemele@users.noreply.github.com> Date: Tue, 25 Feb 2025 10:13:51 +0100 Subject: [PATCH 4/4] reverted changes --- .../didcomm-messaging/did-utils/src/methods/peer/util.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs index 837d4f75..03eb7be2 100644 --- a/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs +++ b/crates/web-plugins/didcomm-messaging/did-utils/src/methods/peer/util.rs @@ -116,7 +116,7 @@ fn are_all_ids_and_references_relative(diddoc: &DIDDocument) -> bool { #[inline] fn check_methods(methods: &Option>, f: impl Fn(&T) -> bool) -> bool { - methods.as_ref().map_or(true, |items| items.iter().all(f)) + methods.as_ref().map_or(true, |items| items.iter().all(f)) } check_methods(&diddoc.verification_method, |method| is_relative(&method.id))