Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat for DataInterpolations v7 #221

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

visr
Copy link
Contributor

@visr visr commented Jan 21, 2025

I didn't see a CompatHelper PR, but see the action failed last two times, not sure why: https://github.com/adrhill/SparseConnectivityTracer.jl/actions/workflows/CompatHelper.yml

The breaking changes relate to the extrapolation API, which doesn't affect this package.
https://github.com/SciML/DataInterpolations.jl/releases/tag/v7.0.0

@adrhill
Copy link
Owner

adrhill commented Jan 24, 2025

Thanks, I'll take a look at fixing CompatHelper as well!

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (c4b1ede) to head (9d60a84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files          30       30           
  Lines        1159     1159           
=======================================
  Hits         1088     1088           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit 54f7c97 into adrhill:main Jan 24, 2025
11 checks passed
@adrhill
Copy link
Owner

adrhill commented Jan 24, 2025

CompatHelper appears to work now! :)

@visr visr deleted the data-interpolations branch January 24, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants