Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jacobian_sparsity for inplace function #223

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Conversation

ErikQQY
Copy link
Contributor

@ErikQQY ErikQQY commented Jan 22, 2025

Fix #222

I'm not sure if the test case is good, gonna need some advice.

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (c4b1ede) to head (3c12d2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   93.87%   93.91%   +0.03%     
==========================================
  Files          30       30              
  Lines        1159     1166       +7     
==========================================
+ Hits         1088     1095       +7     
  Misses         71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill added the run benchmark Run benchmarks in CI label Jan 24, 2025
@adrhill adrhill merged commit 46d9aac into adrhill:main Jan 24, 2025
11 checks passed
@ErikQQY ErikQQY deleted the qqy/inplace branch January 25, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run benchmark Run benchmarks in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undef reference appeared when using jacobian_sparsity for in-place function
3 participants