From bf94bb5b8f0d78ae1972becdc0cb0bbaa9031891 Mon Sep 17 00:00:00 2001
From: Janes Sanne <59392839+JeanAnNess@users.noreply.github.com>
Date: Tue, 29 Oct 2024 15:21:47 +0100
Subject: [PATCH] Fixed automatic feedback for `trace` task in HW2 (#24)

---
 homework/H2_Linear_Algebra.jl | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/homework/H2_Linear_Algebra.jl b/homework/H2_Linear_Algebra.jl
index 33656ab..8ec2138 100644
--- a/homework/H2_Linear_Algebra.jl
+++ b/homework/H2_Linear_Algebra.jl
@@ -820,28 +820,16 @@ else
         # Results
         result_square = trace(A_square)
         result_diagonal = trace(A_diagonal)
-        shouldError = true
-        try
-            result_not_square = trace(A_not_square)
-            shouldError = false
-        catch
-        end
 
 		# Test missing
 		if ismissing(result_square) || ismissing(result_diagonal)
             still_missing()
         # Test for square matrix
-		elseif result_square != result_ref
+        elseif !isapprox(result_square, result_ref, atol=1e-4)
             keep_working(md"Check your implementation for square matrices.")
-
-            # Test for non-square matrix
-        elseif !shouldError
-            keep_working(md"Did you check whether the matrix is a square matrix?")
-
             # Test for diagonal matrix
-        elseif result_diagonal != result_ref
+        elseif !isapprox(result_diagonal, result_ref, atol=1e-4)
             keep_working(md"Check your implementation for diagonal matrices.")
-
         else
             correct()
         end