Upgrade build stack, fix react context changetracking #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the module doesn’t work with inline editing in 5.3+. The reason is that each element is now individually changetracked, and on page save any elements that have changed will be POST-ed before the page then is POST-ed separately.
The most important part here is the additional call to
props.onChange()
as this is what triggers the changetracking. Everything else is QOL stuff really:I’ve set the requirements to SS5 because of the React upgrade. I haven’t actually tested in 4.x, it might be fine, but I don’t see any harm in bumping the requirements and releasing a 1.0.0 instead 😄