Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build stack, fix react context changetracking #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kinglozzer
Copy link

The current version of the module doesn’t work with inline editing in 5.3+. The reason is that each element is now individually changetracked, and on page save any elements that have changed will be POST-ed before the page then is POST-ed separately.

The most important part here is the additional call to props.onChange() as this is what triggers the changetracking. Everything else is QOL stuff really:

  • Upgrading to React 18 / node 18
  • Including plain HTML copies of the fields in non-inline editing mode: this stops changetracking incorrectly marking everything as changed on load (fixes Changetracker fired on load #11)

I’ve set the requirements to SS5 because of the React upgrade. I haven’t actually tested in 4.x, it might be fine, but I don’t see any harm in bumping the requirements and releasing a 1.0.0 instead 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changetracker fired on load
1 participant