Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Abandon intel MacOS CI test runs #1628

Closed
TonyBagnall opened this issue Jun 7, 2024 · 3 comments · Fixed by #1585
Closed

[MNT] Abandon intel MacOS CI test runs #1628

TonyBagnall opened this issue Jun 7, 2024 · 3 comments · Fixed by #1585
Labels
enhancement New feature, improvement request or other non-bug code enhancement maintenance Continuous integration, unit testing & package distribution

Comments

@TonyBagnall
Copy link
Contributor

Describe the feature or idea you want to propose

our macOS tests cause the majority of fails we see. These tests are based on intel Mac OS. Chris is trying to switch over to M1 based tests in #1585

I think the current tests we run are not only pointless, but actually counter productive.

the main source of bugs from mac is due to results reproduction, since numerics are different. The problem is, they are also different between M1 and Intel MacOS. Passing one does not mean you pass the other. This makes the CI ones effectively meaningless. Further, we cannot locally run the CI tests since none of us have an intel based mac.

We also have a problem with #1144. The fixes strangely hang on the CI, but this is not reproducible with M1. I believe tensorflow are no longer supporting intel based tests.

Describe your proposed solution

I think we just abandon all the mac tests and work towards the M1 tests in #1585

Describe alternatives you've considered, if relevant

We could just leave them in, but they are holding up the solution to #1144 where the CI just hangs.

Additional context

No response

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement maintenance Continuous integration, unit testing & package distribution labels Jun 7, 2024
@TonyBagnall
Copy link
Contributor Author

not sure if this is Mac or CI related,
image

@TonyBagnall
Copy link
Contributor Author

MacOS related bugs
#324
#622

@TonyBagnall
Copy link
Contributor Author

and this
#1421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant