-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Merge MiniRocket and MiniRocketMultivariate #1708
Conversation
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Is there a specific reason why you introduce two versions of fit/transform (multi, uni) ? Couldn't we use the multivariate code with |
because its very complicated and I was looking for the simplest solution. Anything more can be done after imo. IIRC angus tried that but there were problems |
I'll try it though .... seems to work! This code has sat here for two or three years :) I'll rerun with full coverage and testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking comments, but computing logic looks fine, test are passing even without numba, so LGTM
merge these two transformers, part of #1699, deprecate multivariate version
based on advice from @baraline, tried merging just using the multivariate version and it worked. Will explore any performance hit later. Prior to #1698, Minirocket and Minirocket multvariate were about 2000 lines long. After this PR combined both will be under 400 lines.
It could be done better, but at this point, with the issue #208 over a year old, I just want to move things forward.