-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Shapelet visualization tools #1715
Conversation
Thank you for contributing to
|
…-visualization-method
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…github.com/aeon-toolkit/aeon into 1703-enh-add-shapelet-visualization-method
awesome stuff, I'll take a look now |
not here obvs, but it would be good to standardise the naming etc with internsal shapelets, eg
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baraline maybe Im just looking in the wrong place, but the shapelet notebook seems not to have changed? Is it possible to demo all this in a notebook?
Hi Tony, the notebook content didn't change, I just opened it, and it seems to have render the image again, leading to à change in the cells metadata. This is probably due to a notebook version change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for this
Reference Issues/PRs
Fixes #1703 #1684
What does this implement/fix? Explain your changes.
Add 3 classes for the following visualisation cases:
ShapeletVisualizer
to visualize one shapelet, its values, itself on a time series on best match location, and its distance vector to a time series.ShapeletTransformerVisualizer
takes a fitted shapelet transformer and useShapeletVisualizer
methods. The shapelet to visualize is specified by ID when calling one of the three functions.ShapeletClassifierVisualizer
takes a fitted shapelet classifier and useShapeletTransformerVisualizer
methods. It adds another method to visualize the best shapelets for a given class. Only linear and forest based classifiers are supported for now.The structure might be a bit naïve for now and could use some refactoring, but I feel like this belong in a future PR.
For use with
ShapeletTransformClassifier
, the rotation forest need to be switched to another classifier.While playing with the new visualisation, I wanted to add the option to switch the distance function used to compute the distance vectors, so I added the
distance
parameter (interfacing with the distance module) toRDST
andShapeletVisualizer
, which uses methods defined inRDST
to compute distance vectors.Example output :
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
As MrSEQL and LS have non-standard structure compared to the others, they might not be supported directly in this PR
PR checklist
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access