Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Piecewise Linear Approximation (PLA) #1807

Merged
merged 52 commits into from
Sep 3, 2024

Conversation

Moonzyyy
Copy link
Contributor

@Moonzyyy Moonzyyy commented Jul 15, 2024

What does this implement/fix? Explain your changes.

Implements #948. Added tests for new series transformer PLA.

Does your contribution introduce a new dependency? If yes, which one?

No new dependency

@Moonzyyy Moonzyyy requested a review from aiwalter as a code owner July 15, 2024 21:16
@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels Jul 15, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Jul 15, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

TonyBagnall
TonyBagnall previously approved these changes Jul 16, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple very minor things, but looks good to me. Could you change the title of the PR, this is just PLA not catch22

@TonyBagnall
Copy link
Contributor

might be worth looking at numba at some point?

@Moonzyyy Moonzyyy changed the title [ENH] PLA and Catch22 [ENH] Piecewise Linear Approximation (PLA) Jul 16, 2024
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I did not notice initially that _fit should not exist due to the tag setting, unless you think it is the tag which is wrong and the method should exist.

I am going to turn on the code coverage tests to its easier to see what lines are covered by unit tests.

@aeon-actions-bot aeon-actions-bot bot added the codecov actions Run the codecov action on a PR label Jul 25, 2024
@MatthewMiddlehurst
Copy link
Member

Could you plot the test series and each of the options similar to the image above? We have utilities in the visualisation module which can do this.

@aeon-actions-bot aeon-actions-bot bot removed the codecov actions Run the codecov action on a PR label Aug 16, 2024
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any comments @TonyBagnall?

@MatthewMiddlehurst MatthewMiddlehurst merged commit 0527349 into aeon-toolkit:main Sep 3, 2024
14 checks passed
@Cyril-Meyer Cyril-Meyer mentioned this pull request Sep 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants