-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Fixes in Catch22 #1809
[ENH] Fixes in Catch22 #1809
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you show some results in the PR body to show this matches the pycatch22 version better? before, after and the source results for a series if possible or a link to said results
Here are the result files. Old: New: Compare To pycatch22: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change _verify_features
to allow usage of the shortened features and then add a test for this?
…s part of features
division by zero in previous notebook test is a bit worrying, no idea what function caused it though. |
… of '_SB_TransitionMatrix_3ac_sumdiagcov', previous push was a mistake
Reference Issues/PRs
Fixes #1384
What does this implement/fix? Explain your changes.
Looked through the original C code implementation found in #1384, and made sure code does not cause issues with Numba.
Does your contribution introduce a new dependency? If yes, which one?
None
Any other comments?
This has not been tested to see if it has fixed #1598. More testing required. From my understanding of messing around with Numba however, it may be worth creating our own np.argsort.