Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Fixes in Catch22 #1809

Merged
merged 31 commits into from
Aug 4, 2024
Merged

Conversation

Moonzyyy
Copy link
Contributor

Reference Issues/PRs

Fixes #1384

What does this implement/fix? Explain your changes.

Looked through the original C code implementation found in #1384, and made sure code does not cause issues with Numba.

Does your contribution introduce a new dependency? If yes, which one?

None

Any other comments?

This has not been tested to see if it has fixed #1598. More testing required. From my understanding of messing around with Numba however, it may be worth creating our own np.argsort.

@Moonzyyy Moonzyyy requested a review from aiwalter as a code owner July 16, 2024 10:26
@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels Jul 16, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Jul 16, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show some results in the PR body to show this matches the pycatch22 version better? before, after and the source results for a series if possible or a link to said results

@Moonzyyy
Copy link
Contributor Author

Here are the result files.

Old:
aeon_catch22_with_numba.xlsx

New:
aeon_catch22_with_numba.xlsx

Compare To pycatch22:
pycatch22_catch22_ipd.xlsx

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change _verify_features to allow usage of the shortened features and then add a test for this?

@aeon-actions-bot aeon-actions-bot bot added the codecov actions Run the codecov action on a PR label Jul 30, 2024
@MatthewMiddlehurst
Copy link
Member

division by zero in previous notebook test is a bit worrying, no idea what function caused it though.
https://github.com/aeon-toolkit/aeon/actions/runs/10159947289/job/28095237710?pr=1809

@MatthewMiddlehurst MatthewMiddlehurst merged commit f523a27 into aeon-toolkit:main Aug 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Update Catch22 transformer
2 participants