Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix DL classification notebook #1862

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

MatthewMiddlehurst
Copy link
Member

What does this implement/fix? Explain your changes.

Fixes the currently breaking example notebook in the periodic tests

https://github.com/aeon-toolkit/aeon/actions/runs/10136750201/job/28025991094

@MatthewMiddlehurst MatthewMiddlehurst added documentation Improvements or additions to documentation classification Classification package examples Example notebook related labels Jul 29, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Jul 29, 2024

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst added the full examples run Run all examples on a PR label Jul 29, 2024
@aeon-actions-bot aeon-actions-bot bot removed the full examples run Run all examples on a PR label Jul 29, 2024
@aeon-actions-bot aeon-actions-bot bot added the full examples run Run all examples on a PR label Jul 29, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review July 29, 2024 22:13
@hadifawaz1999
Copy link
Member

ah this might be my fault with TimeCNN introduction, but weird it didnt break my PR when doing this, we sure this is the casue @MatthewMiddlehurst ?

@MatthewMiddlehurst
Copy link
Member Author

It was not run by default, given the tests pass now I would say yeah this is correct.

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MatthewMiddlehurst MatthewMiddlehurst merged commit b394379 into main Jul 30, 2024
3 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/dl-notebook-fix branch July 30, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package documentation Improvements or additions to documentation examples Example notebook related full examples run Run all examples on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants