-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Improve deep learning networks test coverage #1870
[ENH] Improve deep learning networks test coverage #1870
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! More testing coverage is always welcome.
Rerunning CI so it generates a coverage report, but this all looks good in principle.
good idea this way we can update the issue with the coverage reports, thanks @Cyril-Meyer for the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference Issues/PRs
Improves #1233
What does this implement/fix? Explain your changes.
Add network specific tests to improve coverage of DL networks :
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
AE networks have been ignored as they already have someone working on it with specific tests ref.
There are also 2 networks that can have a better coverage (lite and tapnet) but that have been ignored as they are already skipped in test_all_networks, see #1867.
PR checklist
For all contributions