-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Add metrics parameter for deep clustering module (#1945) #1954
Conversation
Thank you for contributing to
|
@all-contributors please add @neuron283 for maintenance |
@neuron283 I've put up a pull request to add @neuron283! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, can you do the same changes for AEResNet ? the parameter exists but unused yet
Sure. |
it should be all the same way it was done for AEFCN, the same way you did it in this PR for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the PR reverted the changes from the latest PR we got in #1944
Reference Issues/PRs
Fixes #1945
What does this implement/fix?
Adds metrics parameter for deep clustering.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
Let me know if any changes required. Thanks!
PR checklist
For all contributions