Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Add metrics parameter for deep clustering module (#1945) #1954

Closed
wants to merge 8 commits into from
Closed

[MNT] Add metrics parameter for deep clustering module (#1945) #1954

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2024

Reference Issues/PRs

Fixes #1945

What does this implement/fix?

Adds metrics parameter for deep clustering.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

Let me know if any changes required. Thanks!

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@ghost ghost requested review from chrisholder and TonyBagnall as code owners August 12, 2024 14:08
@aeon-actions-bot aeon-actions-bot bot added clustering Clustering package maintenance Continuous integration, unit testing & package distribution labels Aug 12, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@ghost
Copy link
Author

ghost commented Aug 12, 2024

@all-contributors please add @neuron283 for maintenance

Copy link
Contributor

@neuron283

I've put up a pull request to add @neuron283! 🎉

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, can you do the same changes for AEResNet ? the parameter exists but unused yet

@hadifawaz1999 hadifawaz1999 added the deep learning Deep learning related label Aug 12, 2024
@ghost
Copy link
Author

ghost commented Aug 12, 2024

Thanks for taking care of this, can you do the same changes for AEResNet ? the parameter exists but unused yet

Sure.
In AEResNet, the default value of metrics is ["accuracy"] . Should I keep that as it is or change it to ["mean_squared_error"] ?

@hadifawaz1999
Copy link
Member

Thanks for taking care of this, can you do the same changes for AEResNet ? the parameter exists but unused yet

Sure. In AEResNet, the default value of metrics is ["accuracy"] . Should I keep that as it is or change it to ["mean_squared_error"] ?

it should be all the same way it was done for AEFCN, the same way you did it in this PR for now

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the PR reverted the changes from the latest PR we got in #1944

@hadifawaz1999
Copy link
Member

image
the issues seems here, for some reason when mergin the main branch it reverted the latest commit to main

@ghost
Copy link
Author

ghost commented Aug 12, 2024

image the issues seems here, for some reason when mergin the main branch it reverted the latest commit to main

Sorry for inconvenience, I'll open a new PR and make the necessary changes.

@ghost ghost closed this Aug 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clustering Clustering package deep learning Deep learning related maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT] Add metrics parameter for deep clustering module
2 participants