-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add collection transformer for normalisation #2005
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the new transformer, just some comments that i left
would be good to add a test for it , simple one to call it on random data
@hadifawaz1999 The windows 11 python 3.12 test is passing but the windows 11 python 3.11 is failing. can you please check it. |
just re-ran it now, random fail :) |
Are there any more changes needed? |
i would like your input @TonyBagnall on this given you made the feature request |
@hadifawaz1999 I've added the test for normalise class. Any changes to be made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look great thanks, could you just add the transformer to api ? then we can merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if am not mistaken @TonyBagnall standard would mean just zero mean and not divide by std ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this, just need to either change the meaning of standardise or stick with the two allowed values, its up to you
@TonyBagnall can you please help with this error. rather than from aeon.transformations.collection import BaseCollectionTransformer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
What does this implement/fix? Explain your changes.
I have added a new file normalise in aeon\transformations\collection as requested in issue #2000.