Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add collection transformer for normalisation #2005

Merged
merged 28 commits into from
Sep 17, 2024
Merged

[ENH] Add collection transformer for normalisation #2005

merged 28 commits into from
Sep 17, 2024

Conversation

aryanpola
Copy link
Contributor

What does this implement/fix? Explain your changes.
I have added a new file normalise in aeon\transformations\collection as requested in issue #2000.

@aryanpola aryanpola requested a review from aiwalter as a code owner August 23, 2024 05:39
@aeon-actions-bot aeon-actions-bot bot added the transformations Transformations package label Aug 23, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new transformer, just some comments that i left
would be good to add a test for it , simple one to call it on random data

@aryanpola
Copy link
Contributor Author

@hadifawaz1999 The windows 11 python 3.12 test is passing but the windows 11 python 3.11 is failing. can you please check it.

@hadifawaz1999
Copy link
Member

@hadifawaz1999 The windows 11 python 3.12 test is passing but the windows 11 python 3.11 is failing. can you please check it.

just re-ran it now, random fail :)

@aryanpola
Copy link
Contributor Author

@hadifawaz1999 The windows 11 python 3.12 test is passing but the windows 11 python 3.11 is failing. can you please check it.

just re-ran it now, random fail :)

Are there any more changes needed?

@hadifawaz1999
Copy link
Member

i would like your input @TonyBagnall on this given you made the feature request

@aryanpola
Copy link
Contributor Author

@hadifawaz1999 I've added the test for normalise class. Any changes to be made?

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look great thanks, could you just add the transformer to api ? then we can merge it

@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Sep 2, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title Added Methods for Normalisation [ENH] Add collection transformer for normalisation Sep 2, 2024
Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if am not mistaken @TonyBagnall standard would mean just zero mean and not divide by std ?

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, just need to either change the meaning of standardise or stick with the two allowed values, its up to you

@aryanpola
Copy link
Contributor Author

aryanpola commented Sep 16, 2024

INTERNALERROR> ImportError: cannot import name 'BaseCollectionTransformer' from partially initialized module 'aeon.transformations.collection' (most likely due to a circular import) (C:\aeon\aeon\transformations\collection\__init__.py)

@TonyBagnall can you please help with this error.

rather than

from aeon.transformations.collection import BaseCollectionTransformer
use
from aeon.transformations.collection.base import BaseCollectionTransformer

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@TonyBagnall TonyBagnall merged commit 72bf562 into aeon-toolkit:main Sep 17, 2024
14 checks passed
@aryanpola aryanpola deleted the normalise branch September 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants