-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Softmax activation function added #2594
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
Thank you for this but i left a comment on the corresponding issue on how this is not a bug |
Hi, I agree with Ali here if these are the published defaults then I don't really want to change them unless there is a publication showing it is better. @hadifawaz1999 a warning or documentation change should be fine though if you think this would produce better results in certain scenarios? If not or it's unknown, keep it as it is. Up to you really. |
not sure how worth it it would be, its not really the best model at the end of the day, with or without softmax, so would just keep it as is and not add confusion to users |
ok will leave it up for a bit for others to comment but likely declined |
Fixes Issue #2593