Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #5

Open
sa501428 opened this issue May 29, 2020 · 1 comment
Open

code cleanup #5

sa501428 opened this issue May 29, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sa501428
Copy link
Member

For the long-term sustainability of the code, we should make all variables have meaningful names; e.g. targetVector or indicesToIgnore rather than z, b, etc. Ideally we also make them match the names in the Java port: aidenlab/Juicebox@68fa57d

(Java port also needs more code cleanup of names for that matter)
@sa501428 sa501428 added enhancement New feature or request good first issue Good for newcomers labels May 29, 2020
@sa501428
Copy link
Member Author

for variables, methods, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sa501428