Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why we not support jdk 8? #33

Open
citywalki opened this issue Nov 7, 2023 · 8 comments
Open

why we not support jdk 8? #33

citywalki opened this issue Nov 7, 2023 · 8 comments
Assignees

Comments

@citywalki
Copy link

Not all production projects are new versions, most of us are still at jdk8.
please think about this

@aileftech
Copy link
Owner

aileftech commented Nov 7, 2023

You are right. I will make it so that the next release supports JDK >= 8. I don't wanna mess this up though, so I need to check carefully what needs to change.

For sure the java.version = 17 in the pom.xml file. I guess I need to use JDK 8 to compile the project as well otherwise it will not run when installed with Maven?

Thanks for reporting this!

@aileftech aileftech self-assigned this Nov 7, 2023
@aileftech
Copy link
Owner

After some testing I realized I used more Java > 8 features than I expected. I still plan to do this but it will require a bit more time than expected.

@bobgarner
Copy link

I was able to bump my java version to 17 but now I am getting a runtime exception at startup:

Failed to introspect Class [tech.ailef.snapadmin.external.controller.SnapAdminController] from ClassLoader [jdk.internal.loader.ClassLoaders$AppClassLoader@531d72ca]

There is a bunch of org.springframework.beans... in the stack trace, do you have a minimum version for Spring Boot?

@aileftech
Copy link
Owner

I would need to test it, but the lowest I ever tried is 3.1.3. What version are you using?

@bobgarner
Copy link

Ah ok, I am at 2.5.5. That is way to low, I've been meaning to bring it up to date so I will do that.

@DaurenF
Copy link

DaurenF commented Dec 11, 2023

HI! Doesn't it support old version of hibernate (5.x.x) versions?
I get this error after adding it to gradle :

// https://mvnrepository.com/artifact/tech.ailef/snap-admin
implementation 'tech.ailef:snap-admin:0.2.0'

import javax.persistence.Entity;
error: cannot find symbol

@aileftech
Copy link
Owner

Hi, I have not tested with older Hibernate versions but what I can grasp from the error is that it might be related to the javax.persistence to jakarta.persistence renamed package. At the moment I don't have a solution for this though, I guess this would require shipping two different versions of the library?

I'd really like to avoid this so If somebody with more experience is aware of a different method to ship just one version that supports both (assuming it's possible) it'd be awesome.

@ochompsky
Copy link

Not all production projects are new versions, most of us are still at jdk8. please think about this

who is 'most'? why ask the developer to spend his time making this amazing library work because you are too lazy to upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants