Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues and questions #47

Open
daaa57150 opened this issue May 21, 2024 · 1 comment
Open

Multiple issues and questions #47

daaa57150 opened this issue May 21, 2024 · 1 comment
Assignees

Comments

@daaa57150
Copy link

daaa57150 commented May 21, 2024

Hi,

This is a summary of what went wrong or felt missing during me playing with snap admin. I figured I would make only one issue and then if you want you can pick what you think needs attention and what doesn't

  1. Boolean fields (with an uppercase B) were giving me an error "Unable to find getter method for field", because Lombok generates the getter as getXxxx instead of isXxxx. I think we should not use the Uppercase Boolean in our project, but maybe your code could also allow both getter names ?

  2. boolean fields starting with is have a getter named the same as the property when generated with Lombok. Maybe also take care of this ? We have a property named isSomething, snap admin looks for a getter named isIsSomething(). I simply created one myself for now.

  3. @Embedded is not supported, I think it could be nice to have that

  4. boolean fields are edited in full text, they could be checkboxes, also in consultation (list/details) just a checkmark or a cross would be better

  5. Long texts could be annotated with something so that the ui displays a textarea

  6. Saving in the settings panel throws "Error resolving template [settings/settings]". They are saved though, it just looks like a bad redirect after the fact.

  7. A field with both @HiddenColumn and @Filterable won't provide filters. This is what I wanted:

    • Hide the foreign key UUID because it's ugly and takes so much space
    • Add a computed column instead, using the @DisplayName method on the related entity for the value
    • Have the @Filterable active on the hidden UUID, because the filter works when searching for the result of the @DisplayName method on the related entity
      ApplicationFrameHost_zmm8aDbci1
      => It would be nice to be able to support @Filterable on the @ComputedColumn maybe ?
  8. Add a way to hide the settings panel. Once it's configured I'd rather not have our admin users have access to that.

  9. When editing an association, it's possible to search the results of the @DisplayName on the referenced entity, but once chosen, it's not displayed. Would be nice to display it under the field for example.
    msedge_ZMixFFkZwa
    msedge_uHCETHuqQ1

  10. There is no way to customize the name of the fields, they are displayed with underscores

  11. How do I hide a column in a list but display it in the details ?

  12. How to convert the OffsetDateTimes to a specific timezone for display and edition ? I'm displaying them with @DisplayFormat(format = "%tF") for example, but they are GMT and it doesn't make much sense for the users, GMT is how they are stored in the DB.

  13. @Ids are not @Filterable
    msedge_59fgs2xARl

  14. Saving an OffsetDateTime throws an exception:
    eclipse_7w2vAPdEvY

  15. Some OffsetDateTimes are not displayed in the edit page:
    msedge_r59JdGuSSd

I'm pretty sure there are things that need more explaination, don't hesitate to ask.

I'm really looking forward to this project, it has so much potential!

@aileftech
Copy link
Owner

Hey @daaa57150, wow! Thanks for this detailed feedback, it's really much appreciated.

I'm going to have to take some time to understand everything here and I'll try to come back at you as soon as possible.

@aileftech aileftech self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants