From b091366e59f847922aac8f476c26b7dfd8b85d9d Mon Sep 17 00:00:00 2001
From: h0ngcha0 <lbs.lhc@gmail.com>
Date: Fri, 19 Apr 2024 13:01:26 +0200
Subject: [PATCH] Remove approve field from SignExecuteContractMethodParams<T

---
 packages/web3/src/contract/contract.ts | 30 +++++++++++++-------------
 test/contract.test.ts                  |  6 +-----
 2 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/packages/web3/src/contract/contract.ts b/packages/web3/src/contract/contract.ts
index ef188741d..06c02b995 100644
--- a/packages/web3/src/contract/contract.ts
+++ b/packages/web3/src/contract/contract.ts
@@ -1778,10 +1778,6 @@ export interface SignExecuteContractMethodParams<T extends Arguments = Arguments
   signer: SignerProvider
   attoAlphAmount?: Number256
   tokens?: Token[]
-  approve?: {
-    attoAlphAmount?: Number256
-    tokens?: Token[]
-  }
   gasAmount?: number
   gasPrice?: Number256
 }
@@ -2297,7 +2293,13 @@ export async function signExecuteMethod<I extends ContractInstance, F extends Fi
   const methodIndex = contract.contract.getMethodIndex(methodName)
   const functionSig = contract.contract.functions[methodIndex]
 
-  const bytecodeTemplate = getBytecodeTemplate(methodIndex, functionSig, contract.contract.structs, params.approve)
+  const bytecodeTemplate = getBytecodeTemplate(
+    methodIndex,
+    functionSig,
+    contract.contract.structs,
+    params.attoAlphAmount,
+    params.tokens
+  )
 
   const fieldsSig = toFieldsSig(contract.contract.name, functionSig)
   const bytecode = ralph.buildScriptByteCode(
@@ -2326,10 +2328,8 @@ function getBytecodeTemplate(
   methodIndex: number,
   functionSig: FunctionSig,
   structs: Struct[],
-  approve?: {
-    attoAlphAmount?: Number256
-    tokens?: Token[]
-  }
+  attoAlphAmount?: Number256,
+  tokens?: Token[]
 ): string {
   // For the default TxScript main function
   const numberOfMethods = '01'
@@ -2340,8 +2340,10 @@ function getBytecodeTemplate(
 
   const [templateVarStoreLocalInstrs, templateVarsLength] = getTemplateVarStoreLocalInstrs(functionSig, structs)
 
-  const approveAlphInstrs: string[] = getApproveAlphInstrs(approve?.attoAlphAmount)
-  const approveTokensInstrs: string[] = getApproveTokensInstrs(approve?.tokens)
+  const approveAlphInstrs: string[] = getApproveAlphInstrs(
+    functionSig.usePreapprovedAssets ? attoAlphAmount : undefined
+  )
+  const approveTokensInstrs: string[] = getApproveTokensInstrs(functionSig.usePreapprovedAssets ? tokens : undefined)
   const callerInstrs: string[] = getCallAddressInstrs(approveAlphInstrs.length / 2 + approveTokensInstrs.length / 3)
 
   // First template var is the contract
@@ -2407,10 +2409,8 @@ function getApproveTokensInstrs(tokens?: Token[]): string[] {
   const approveTokensInstrs: string[] = []
   if (tokens) {
     tokens.forEach((token) => {
-      const tokenId = byteStringCodec.encodeBuffer(Buffer.from(token.id, 'hex'))
-      const tokenAmount = encodeU256Const(BigInt(token.amount))
-      approveTokensInstrs.push('14' + tokenId.toString('hex'))
-      approveTokensInstrs.push(tokenAmount)
+      approveTokensInstrs.push('14' + byteStringCodec.encodeBuffer(Buffer.from(token.id, 'hex')).toString('hex'))
+      approveTokensInstrs.push(encodeU256Const(BigInt(token.amount)))
       approveTokensInstrs.push(encodeInstr(ApproveToken))
     })
   }
diff --git a/test/contract.test.ts b/test/contract.test.ts
index b2c5f6696..45ed44869 100644
--- a/test/contract.test.ts
+++ b/test/contract.test.ts
@@ -609,11 +609,7 @@ describe('contract', function () {
       },
       signer,
       attoAlphAmount: ONE_ALPH * 2n,
-      tokens: [{ id: sub.contractInstance.contractId, amount: 200n }],
-      approve: {
-        attoAlphAmount: ONE_ALPH,
-        tokens: [{ id: sub.contractInstance.contractId, amount: 200n }]
-      }
+      tokens: [{ id: sub.contractInstance.contractId, amount: 200n }]
     })
 
     const afterBalances = await signer.nodeProvider.addresses.getAddressesAddressBalance(signerAddress)