Tx Codec #276
Merged
Tx Codec #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Dec 19, 2023
Lbqds
reviewed
Mar 23, 2024
| with: | ||
| version: 7.19 | ||
| version: 8.14 |
There was a problem hiding this comment.
It seems that pnpm 7.19 also works. Just curious, what is the reason for upgrading the pnpm version?
There was a problem hiding this comment.
IIRC, these two versions generate different pnpm.lock file, which will fail CI since CI checks if the git repo is clean after building
There was a problem hiding this comment.
Thanks for the explanation, I'll update the pnpm version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.