Reposition and add file name to compilation error #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0ngcha0
reviewed
Feb 22, 2024
| const errorRegex = /error \((\d+):(\d+)\):\s*(.*)\n\s*(\d+)\s*\|(.*)\n.*\|(.*)\n\s*\|(.*)(?:\n\s*\|(.*)\n\s*\|(.*))?/ | ||
|
|
||
| export function parseError(error: string): CompilationError | undefined { | ||
| const match = error.match(errorRegex) |
There was a problem hiding this comment.
[Nit] If for some reason this doesn't match the error regex, does it make sense to fall back to the original error? Otherwise I guess we might get regex error below.
There was a problem hiding this comment.
we throw it here when we use the parsing function.
| ${spaces} |${this.errorIndicator} | ||
| ${spaces} |${this.message}` | ||
|
|
||
| if (this.additionalLine1 && this.additionalLine2) { |
There was a problem hiding this comment.
Q: What is additionalLine1 and additionalLine2? Is it footer?
There was a problem hiding this comment.
Some errors can have a "hint" footer, see this example from the test Those are "real" error generated by our node CompilerSpec
There was a problem hiding this comment.
I need to take the lines separately, because I have to adapt the spaces before the |.
| return line >= sourceInfoWithLine.startIndex && line <= sourceInfoWithLine.endIndex | ||
| }) | ||
|
|
||
| if (sourceInfo === undefined) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the error message coming from the node compilation and shift the index, as well as adding the file name to the error.
Received from node:
after: