Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk to support rhone upgrade #351

Merged
merged 4 commits into from
May 24, 2024
Merged

Update sdk to support rhone upgrade #351

merged 4 commits into from
May 24, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented May 13, 2024

  1. Remove unnecessary fields from the artifact
  2. Add the @using(methodSelector = false) annotation to existing std interfaces
  3. Add a skipSaveArtifacts flag in the CLI:
    1. If skipSaveArtifacts is enabled or the contracts have been deployed on the mainnet, we won't regenerate bytecode for those unchanged contract
    2. If the existing contract code is changed, we will regenerate bytecode for the contract
    3. If the existing contract code remains unchanged but new contracts are added, we will only regenerate bytecode for the new contracts

Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polarker polarker merged commit 9e9ab70 into master May 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants