Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block subscription #355

Merged
merged 8 commits into from
May 25, 2024
Merged

Add block subscription #355

merged 8 commits into from
May 25, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented May 23, 2024

No description provided.

@Lbqds Lbqds requested review from h0ngcha0 and polarker and removed request for h0ngcha0 May 23, 2024 05:11
h0ngcha0
h0ngcha0 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

polarker
polarker approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks, otherwise LGTM 👍

@polarker polarker merged commit cc74532 into master May 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarker polarker polarker approved these changes

@h0ngcha0 h0ngcha0 h0ngcha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lbqds @polarker @h0ngcha0