Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Buffer with Uint8Array in codec #363

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Jun 4, 2024

Currently, our codec uses Buffer, which is imported from buffer/. But it is not compatible with Uint8Array.

Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polarker
Copy link
Member

polarker commented Jun 4, 2024

@Lbqds Yes. Let's take the chance to remove Buffer completely from the project, not just codec.

@Lbqds
Copy link
Member Author

Lbqds commented Jun 4, 2024

Replaced all Buffer with Uint8Array in the web3 package.

Copy link
Member

@polarker polarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@polarker polarker merged commit 71691a7 into master Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants