-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Buffer with Uint8Array in codec #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job man!
Just my 2 cents, once the need for Buffer
is removed, how about cleaning up the webpack polyfills as well?
@Lbqds Yes. Let's take the chance to remove |
Replaced all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently, our codec uses
Buffer
, which is imported frombuffer/
. But it is not compatible withUint8Array
.