Minor Updates #403
Merged
Minor Updates #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lbqds
approved these changes
Jul 29, 2024
| @@ -1725,14 +1725,15 @@ function getBytecodeTemplate( | |||
| // For the default TxScript main function | |||
| const numberOfMethods = '01' | |||
| const isPublic = '01' | |||
| const modifier = usePreapprovedAssets ? '03' : '00' | |||
| const scriptUseApprovedAssets = attoAlphAmount !== undefined || tokens !== undefined | |||
There was a problem hiding this comment.
Question: In what situations does a contract method use preapproved assets, but the script does not use preapproved assets?
There was a problem hiding this comment.
That's impossible, but it's possible that the method does not use preapproved assets, but the script use preapproved assets. E.g. the withdraw function of token faucet.
There was a problem hiding this comment.
Got it, thanks for the explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.