Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display the desktop wallet connect option when using a mobile d… #413

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Aug 29, 2024

Resolves issue #412

@polarker polarker merged commit d5ae4b3 into master Aug 29, 2024
6 of 7 checks passed
@nop33
Copy link
Member

nop33 commented Aug 29, 2024

Now that we are at it, shouldn't we also hide the "Extension Wallet" when we are on mobile? What's the point of showing it there? That would mean that when we are on mobile, clicking the "Connect" button will only show 1 connector: WalletConnect. Couldn't we simplify that further and directly trigger the WalletConnect button when the "Connect" button is clicked? This saves the mobile user some confusion and some clicks.

cc @polarker @Lbqds

@Lbqds
Copy link
Member Author

Lbqds commented Aug 29, 2024

Now that we are at it, shouldn't we also hide the "Extension Wallet" when we are on mobile? What's the point of showing it there? That would mean that when we are on mobile, clicking the "Connect" button will only show 1 connector: WalletConnect. Couldn't we simplify that further and directly trigger the WalletConnect button when the "Connect" button is clicked? This saves the mobile user some confusion and some clicks.

cc @polarker @Lbqds

Sounds great 👍, I will improve this.

@MaudSimon
Copy link
Member

I just want to mention that there are users using the web extension on mobile using browsers like Mises browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants