Update multicall #426
Merged
Update multicall #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work as expected due to limits of TS compiler |
|
@h0ngcha0 This is now ready for review! |
h0ngcha0
approved these changes
Oct 2, 2024
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| | (type extends Function ? type : never) | ||
| | (type extends bigint | boolean | number | string ? type : never) | ||
| | (type extends [] ? [] : never) |
There was a problem hiding this comment.
Seems that we can remove this line (here)
There was a problem hiding this comment.
He reverted that comment in another post. I will leave it untouched. It's the same code used in Viem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have better types for multicall as requested by reed