Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Re-rendering fix for Hooks #178

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"packages": ["packages/*"],
"version": "0.8.11",
"version": "0.8.12",
"npmClient": "yarn",
"useWorkspaces": true
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "0.8.11",
"version": "0.8.12",
"private": true,
"name": "alephium-browser-extension-wallet",
"repository": "github:alephium/extension-wallet",
Expand Down
2 changes: 1 addition & 1 deletion packages/dapp/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@alephium/dapp",
"version": "0.8.11",
"version": "0.8.12",
"private": true,
"scripts": {
"dev": "next dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/manifest/v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://json.schemastore.org/chrome-manifest.json",
"name": "Alephium Extension Wallet",
"description": "Alephium's official extension wallet with powerful features and a clean UI.",
"version": "0.8.11",
"version": "0.8.12",
"manifest_version": 2,
"browser_action": {
"default_icon": {
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/manifest/v3.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://json.schemastore.org/chrome-manifest.json",
"name": "Alephium Extension Wallet",
"description": "Alephium's official extension wallet with powerful features and a clean UI.",
"version": "0.8.11",
"version": "0.8.12",
"manifest_version": 3,
"action": {
"default_icon": {
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@alephium/extension",
"version": "0.8.11",
"version": "0.8.12",
"main": "index.js",
"license": "MIT",
"devDependencies": {
Expand Down
21 changes: 7 additions & 14 deletions packages/extension/src/shared/storage/hooks.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { memoize, isEqual } from "lodash-es"
import { memoize } from "lodash-es"
import { useCallback, useEffect, useMemo, useState } from "react"

import { swrCacheProvider } from "../../ui/services/swr"
Expand All @@ -18,11 +18,8 @@ export function useKeyValueStorage<

const set = useCallback(
(value: T[K]) => {
const k = storage.namespace + ":" + key.toString()
if (!isEqual(swrCacheProvider.get(k), value)) {
swrCacheProvider.set(k, value)
setValue(value)
}
swrCacheProvider.set(storage.namespace + ":" + key.toString(), value)
setValue(value)
},
[key, storage.namespace],
)
Expand All @@ -43,10 +40,8 @@ export function useObjectStorage<T>(storage: IObjectStorage<T>): T {

const set = useCallback(
(value: T) => {
if (!isEqual(swrCacheProvider.get(storage.namespace), value)) {
swrCacheProvider.set(storage.namespace, value)
setValue(value)
}
swrCacheProvider.set(storage.namespace, value)
setValue(value)
},
[storage.namespace],
)
Expand Down Expand Up @@ -75,10 +70,8 @@ export function useArrayStorage<T>(

const set = useCallback(
(value: T[]) => {
if (!isEqual(swrCacheProvider.get(storage.namespace), value)) {
swrCacheProvider.set(storage.namespace, value)
setValue(value)
}
swrCacheProvider.set(storage.namespace, value)
setValue(value)
},
[storage.namespace],
)
Expand Down
2 changes: 1 addition & 1 deletion packages/stack-router/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@argent/stack-router",
"version": "0.8.11",
"version": "0.8.12",
"license": "MIT",
"private": true,
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/storybook/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@argent-x/storybook",
"version": "0.8.11",
"version": "0.8.12",
"private": true,
"devDependencies": {
"@alephium/extension": "^0.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@argent/ui",
"version": "0.8.11",
"version": "0.8.12",
"license": "MIT",
"private": true,
"files": [
Expand Down
Loading