Revert "Make injection of inpage.js on dapps synchronous" #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced this change to address the issue of asynchronous loading of
inpage.js. However, this change causes the extension background to be unable to receive connection messages sent by the dApp when the extension's server worker restarts. I’m still unclear about the exact reason behind this.Previously, I noticed that Rabby wallet also used the same approach to inject
inpage.js. However, for unknown reasons, they reverted this change in a later PR.I will look into alternative methods to solve the issue of asynchronous loading of
inpage.js.