Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart #436

Closed
ganievs opened this issue Jul 27, 2023 · 9 comments
Closed

Helm chart #436

ganievs opened this issue Jul 27, 2023 · 9 comments

Comments

@ganievs
Copy link
Contributor

ganievs commented Jul 27, 2023

Hi @alexandrevilain! First of all, I come to say you've done great work!
I made a test setup of the operator and would like to use it as the main way to manage our Temporal clusters in the future and it would be great if the operator will have the ability to install it through the helm.

@ganievs
Copy link
Contributor Author

ganievs commented Jul 27, 2023

I've prepared PR #437 with the chart generation. Would be great if you add it to your release pipeline.

@alexandrevilain
Copy link
Owner

alexandrevilain commented Jul 27, 2023

Thanks for your contribution!
That's a really great idea!
Don't you think it could be better to run the helmify command only one time and push the first version of the helm chart in the PR ?

Then we'll have to:

  • update the "prepare-release" target to update helm chart
  • find a way to host charts maybe using github pages
  • update the release workflow to push the helm chart for each new releases.

What do you think ?

@ganievs
Copy link
Contributor Author

ganievs commented Jul 31, 2023

I think the best option is to use https://github.com/helm/chart-releaser-action as a starting point.
The final release action will look like that
But you already have a static site on the operator repo, so might be good to set up publishing in another repo

@ganievs
Copy link
Contributor Author

ganievs commented Aug 1, 2023

Also, a possible way is to push the chart package to GitHub's package registry.

Here is an example from my fork repo:

Chart publication

$ make helm 
$ helm package charts/temporal-operator
$ helm registry login ghcr.io --username ganievs
$ helm push ./temporal-operator-0.1.0.tgz oci://ghcr.io/ganievs/temporal-operator

Chart installation

$ helm template temporal-operator oci://ghcr.io/ganievs/temporal-operator/temporal-operator --version 0.1.0
$ helm install temporal-operator  oci://ghcr.io/ganievs/temporal-operator/temporal-operator --version 0.1.0

@alexandrevilain
Copy link
Owner

Good idea!
Pushing the chart as oci artifact is IMO the best option!

Don't you think it could be better to run the helmify command only one time and push the first version of the helm chart in the PR ?`

Don't you want to update the pull request with my previous comment ? Then we could add the chart to the oci repo !

Thanks again for your work 👍

@ganievs
Copy link
Contributor Author

ganievs commented Aug 5, 2023

Ok, will do

@ganievs
Copy link
Contributor Author

ganievs commented Aug 7, 2023

Hi @alexandrevilain! So, I rebased from the main and add pushed generated chart in the PR.

@alexandrevilain
Copy link
Owner

Cool! Thanks @ganievs ! I'll take time to carefully review it after the 0.15.0 release.
Looks like the generated values.yaml is a little bit complicated, IMO the controllerManager.manager it too much.
I like simpler formats like cert-manager: https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/values.yaml

But I'll try provide valuable comments on the PR 👍

@alexandrevilain
Copy link
Owner

Now that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants