Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScpFileStat is currently unusable #290

Open
ssnover opened this issue Jun 8, 2023 · 2 comments
Open

ScpFileStat is currently unusable #290

ssnover opened this issue Jun 8, 2023 · 2 comments
Labels
enhancement

Comments

@ssnover
Copy link

ssnover commented Jun 8, 2023

I'm currently using the ssh2::session::Session::scp_recv api which returns a tuple of the Channel and the ScpFileStat, however the ScpFileStat is pretty much just an opaque blob as it doesn't appear to implement any conversion traits.

Would you approve an MR introducing methods to make the internal data accessible?
@ssnover
Copy link
Author

ssnover commented Jun 8, 2023

Would maybe make sense to make the FileStat struct more generalized (break it out of the sftp module) and have a conversion from ScpFileStat into FileStat?

@yodaldevoid
Copy link
Collaborator

Hello and thank you for submitting this issue.

Would you approve an MR introducing methods to make the internal data accessible?

Yes, we would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yodaldevoid @ssnover