Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard-interactive authentication panics - with a potential fix #318

Closed
ayourtch opened this issue Jun 3, 2024 · 1 comment
Closed

Comments

@ayourtch
Copy link

ayourtch commented Jun 3, 2024

The handler for keyboard-interactive uses from_raw_parts(), and several fields get null pointer and zero length passed, which results in panics.

I have fixed it in my own fork here - master...ayourtch:ssh2-rs:fix-interactive-auth - is it something that you would entertain having me open a PR for ? Anything that I should update ?

(I was thinking running cargo fmt, but from experience, it sometimes behaves slightly differently depending on the version, so I deliberately avoided it).

Thanks!

@yodaldevoid
Copy link
Collaborator

Fixed by #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants