Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source term consistency with documentation #3

Open
hemmer opened this issue Dec 18, 2019 · 0 comments
Open

Source term consistency with documentation #3

hemmer opened this issue Dec 18, 2019 · 0 comments

Comments

@hemmer
Copy link

hemmer commented Dec 18, 2019

I have a question about a piece of the source term:

https://github.com/akdiem/vampy/blob/22eb195240ffaec01c15fad804f9eeb90bbb3ae2/vampy/artery.py#L181

From equation 4 in http://openresearchsoftware.metajnl.com/articles/10.5334/jors.159/ it looks like this should be R = np.sqrt(a/np.pi) instead, as the dynamic radius should be used? Maybe I'm misunderstanding the equations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant