From 537b411e8ef58fba614d53c143dbf2fb2eba7c81 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 12:20:15 +0200
Subject: [PATCH 01/19] More specific output for test

---
 tests/test.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/test.py b/tests/test.py
index c4e6ee7..243f621 100644
--- a/tests/test.py
+++ b/tests/test.py
@@ -76,7 +76,9 @@ def test_datasets(self) -> None:
 
                         is_close = np.isclose(py_result, c_result)
 
-                        assert is_close.all()
+                        assert is_close.all(), (
+                            py_result.values[~is_close] - c_result.values[~is_close]
+                        )
 
 
 if __name__ == "__main__":

From 4631a1d336dad1fcecbd1518fdc0c1046fa4588b Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 12:28:48 +0200
Subject: [PATCH 02/19] Change the order of the initializers

---
 bico/clustering/bico.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index 362d620..4fcf75d 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -524,22 +524,22 @@ template<template <typename> class P = std::less> struct comparePairFirst
 
 template<typename T> Bico<T>::Bico(size_t dim, size_t k, size_t p, size_t nMax, int seed,
                                    DissimilarityMeasure<T>* measure, WeightModifier<T>* weightModifier) :
+k(k),
+L(p),
 nodeIdCounter(0),
 measure(measure->clone()),
 weightModifier(weightModifier->clone()),
 maxNumOfCFs(nMax),
 curNumOfCFs(0),
-k(k),
-L(p),
+dimension(dim),
 optEst(-1),
 root(new BicoNode(*this)),
 bufferPhase(true),
-numOfRebuilds(0),
 buffer(),
 projection_buffer(),
 minDist(std::numeric_limits<double>::infinity()),
 pairwise_different(0),
-dimension(dim)
+numOfRebuilds(0)
 {
     Randomness::initialize(seed);
     RandomGenerator rg = Randomness::getRandomGenerator();

From 0d3998233ae287ca1e26462b7395b9198942ca5e Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 12:40:17 +0200
Subject: [PATCH 03/19] Change int to sizet and remove unused variable

---
 bico/clustering/bico.h | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index 4fcf75d..a0b8a52 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -152,7 +152,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                 {
                     // Search for the projection with smallest bucket size
                     mins = outer.buckets[mini][bucket_min].size();
-                    for (int i = 1; i < outer.L; i++)
+                    for (size_t i = 1; i < outer.L; i++)
                     {
                         val = outer.project(element, i);
                         bucket_number = outer.calcBucketNumber(i, val);
@@ -568,17 +568,17 @@ numOfRebuilds(0)
         };
     #endif
 
-    for (int i = 0; i < L; i++)
+    for (size_t i = 0; i < L; i++)
     {
         maxVal[i] = -1;
         norm = 0.0;
-        for (int j = 0; j < dimension; j++)
+        for (size_t j = 0; j < dimension; j++)
         {
             rndpoint[j] = getRandomValue();
             norm += rndpoint[j] * rndpoint[j];
         }
         norm = std::sqrt(norm);
-        for (int j = 0; j < dimension; j++)
+        for (size_t j = 0; j < dimension; j++)
         {
             rndpoint[j] /= norm;
         }
@@ -604,7 +604,7 @@ template<typename T> void Bico<T>::initializeNN()
 {
     double maxBuckets = 10000;
     double Size = 0;
-    for (int i = 0; i < L; i++)
+    for (size_t i = 0; i < L; i++)
     {
         // Compute new bucket size
         if (buckets[i].size() == 1)
@@ -621,7 +621,7 @@ template<typename T> void Bico<T>::initializeNN()
                 Size = (int) ceil((borders[i].second - borders[i].first) / (double) bucket_radius[i]);
             }
         }
-        for (int l = 0; l < buckets[i].size(); l++) buckets[i][l].clear();
+        for (size_t l = 0; l < buckets[i].size(); l++) buckets[i][l].clear();
         // Create new buckets
         buckets[i].clear();
         buckets[i].resize((int) ceil(Size));
@@ -635,11 +635,11 @@ template<typename T> void Bico<T>::allocateBucket(int bucket, bool left)
         // Push front bucket
         borders[bucket].first = 2 * borders[bucket].first - borders[bucket].second;
         std::vector < std::vector<typename BicoNode::FeatureList::iterator >> a(2 * buckets[bucket].size());
-        for (int i = 0; i < buckets[bucket].size(); i++)
+        for (size_t i = 0; i < buckets[bucket].size(); i++)
         {
             a[buckets[bucket].size() + i] = buckets[bucket][i];
         }
-        for (int l = 0; l < buckets[bucket].size(); l++) buckets[bucket][l].clear();
+        for (size_t l = 0; l < buckets[bucket].size(); l++) buckets[bucket][l].clear();
         buckets[bucket].clear();
         buckets[bucket] = a;
     }
@@ -648,11 +648,11 @@ template<typename T> void Bico<T>::allocateBucket(int bucket, bool left)
         // Push back bucket
         borders[bucket].second = 2 * borders[bucket].second - borders[bucket].first;
         std::vector < std::vector<typename BicoNode::FeatureList::iterator >> a(2 * buckets[bucket].size());
-        for (int i = 0; i < buckets[bucket].size(); i++)
+        for (size_t i = 0; i < buckets[bucket].size(); i++)
         {
             a[i] = buckets[bucket][i];
         }
-        for (int l = 0; l < buckets[bucket].size(); l++) buckets[bucket][l].clear();
+        for (size_t l = 0; l < buckets[bucket].size(); l++) buckets[bucket][l].clear();
         buckets[bucket].clear();
         buckets[bucket] = a;
     }
@@ -661,7 +661,7 @@ template<typename T> void Bico<T>::allocateBucket(int bucket, bool left)
 template<typename T> double Bico<T>::project(T point, int i)
 {
     double ip = 0.0;
-    for (int j = 0; j < dimension; j++)
+    for (size_t j = 0; j < dimension; j++)
     {
         ip += point[j]*(rndprojections[i][j]);
     }
@@ -700,7 +700,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
     if (bufferPhase)
     {
         // Update bucket configuration
-        for (int i = 0; i < L; i++)
+        for (size_t i = 0; i < L; i++)
         {
             double val = std::abs(project(element, i));
             if (val > maxVal[i] || maxVal[i] == -1)
@@ -722,14 +722,12 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
         {
             // Sort projection values and determine smallest distance on projection line
             std::sort(projection_buffer.begin(), projection_buffer.end(), comparePairFirst<>());
-            double minProjDist = std::numeric_limits<double>::infinity();
             double minProjRealDist = std::numeric_limits<double>::infinity();
-            for(int i = 0; i < pairwise_different-2; ++i)
+            for(size_t i = 0; i < pairwise_different-2; ++i)
             {
                 double tmpDist = projection_buffer[i+1].first - projection_buffer[i].first;
                 if(tmpDist < minProjRealDist)
                 {
-                    minProjDist = tmpDist;
                     double tmpMinProjRealDist = measure->dissimilarity(*projection_buffer[i].second, *projection_buffer[i+1].second);
                     if(tmpMinProjRealDist > 0)
                     {
@@ -744,7 +742,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
             double lowerEnd = projection_buffer[0].first;
             double upperEnd = lowerEnd + minProjRealDist;
             double minDist = minProjRealDist;
-            for(int i = 0; i < pairwise_different-1; ++i)
+            for(size_t i = 0; i < pairwise_different-1; ++i)
             {
                 if(projection_buffer[i].first >= upperEnd)
                 {
@@ -775,7 +773,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
             //std::cout << "optEst  = " << minDist << std::endl;
             long long int radius = (long long int) ceil(sqrt(getR(1)));
             borders.resize(L);
-            for (int i = 0; i < L; i++)
+            for (size_t i = 0; i < L; i++)
             {
                 borders[i].first = -maxVal[i];
                 borders[i].second = maxVal[i];
@@ -797,7 +795,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
 
 template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::iterator iteratorElement)
 {
-    for (int i = 0; i < L; i++)
+    for (size_t i = 0; i < L; i++)
     {
         double val = project(iteratorElement->first.representative, i);
         int bucket_number = calcBucketNumber(i, val);

From 500fc2ba0ec614d47940130da603622e22602e24 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 12:55:13 +0200
Subject: [PATCH 04/19] Cast size_t to int for comparison warning

---
 bico/clustering/bico.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index a0b8a52..c9e174e 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -143,7 +143,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                 int bucket_min = bucket_number;
                 int mins;
 
-                if ((bucket_number < 0) || (bucket_number > outer.buckets[0].size() - 1))
+                if ((bucket_number < 0) || (bucket_number > (int) outer.buckets[0].size() - 1))
                 {
                     // The bucket does not exist (yet)
                     mins = 0;
@@ -156,7 +156,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                     {
                         val = outer.project(element, i);
                         bucket_number = outer.calcBucketNumber(i, val);
-                        if ((bucket_number >= 0) & (bucket_number <= outer.buckets[i].size() - 1))
+                        if ((bucket_number >= 0) & (bucket_number <= (int) outer.buckets[i].size() - 1))
                         {
                             int s = outer.buckets[i][bucket_number].size();
                             if (s < mins)
@@ -185,7 +185,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                     // Bucket does not exist => create one
                     outer.allocateBucket(rnd, true);
                 }
-                else if (bucket_number > outer.buckets[rnd].size() - 1)
+                else if (bucket_number > (int) outer.buckets[rnd].size() - 1)
                 {
                     // Bucket does not exist => create one
                     outer.allocateBucket(rnd, false);
@@ -808,9 +808,9 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
                 bucket_number = calcBucketNumber(i, val);
             }
         }
-        else if (bucket_number > buckets[i].size() - 1)
+        else if (bucket_number > (int) buckets[i].size() - 1)
         {
-            while (bucket_number > buckets[i].size() - 1)
+            while (bucket_number > (int) buckets[i].size() - 1)
             {
                 allocateBucket(i, false);
                 bucket_number = calcBucketNumber(i, val);

From 799e41b4bcd96cd91609514cc5ed230ccdfdc5f1 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:02:29 +0200
Subject: [PATCH 05/19] Convert weights to size_t

---
 bico/_core.cpp             | 6 +++---
 bico/base/weightedobject.h | 4 ++--
 bico/clustering/cfentry.h  | 2 +-
 bico/core.py               | 2 +-
 bico/point/point.h         | 6 +++---
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/bico/_core.cpp b/bico/_core.cpp
index 0e08e4f..9df3c32 100644
--- a/bico/_core.cpp
+++ b/bico/_core.cpp
@@ -35,7 +35,7 @@ class BicoExternal
     virtual ~BicoExternal();
     void addData(double const *array, uint n);
     void addPoint(double const *array);
-    int compute(int *sample_weights,
+    int compute(size_t *sample_weights,
                 double *points);
 
 private:
@@ -66,7 +66,7 @@ void BicoExternal::addPoint(double const *array)
     *_bico << p;
 }
 
-int BicoExternal::compute(int *sample_weights,
+int BicoExternal::compute(size_t *sample_weights,
                           double *points)
 {
     // Retrieve coreset
@@ -123,7 +123,7 @@ extern "C"
 #if defined(_WIN32) || defined(__CYGWIN__)
     __declspec(dllexport)
 #endif
-    int compute(BicoExternal *bico, int *sample_weights,
+    int compute(BicoExternal *bico, size_t *sample_weights,
                 double *points) { return bico->compute(sample_weights, points); }
 
 #if defined(_WIN32) || defined(__CYGWIN__)
diff --git a/bico/base/weightedobject.h b/bico/base/weightedobject.h
index 1fc07da..90844ca 100644
--- a/bico/base/weightedobject.h
+++ b/bico/base/weightedobject.h
@@ -10,8 +10,8 @@ namespace CluE
 class WeightedObject
 {
 public:
-	virtual double getWeight() const = 0;
-	virtual void setWeight(double w) = 0;
+	virtual size_t getWeight() const = 0;
+	virtual void setWeight(size_t w) = 0;
 };
 
 }
diff --git a/bico/clustering/cfentry.h b/bico/clustering/cfentry.h
index 2fc497e..d75a43d 100644
--- a/bico/clustering/cfentry.h
+++ b/bico/clustering/cfentry.h
@@ -138,4 +138,4 @@ template<typename T> double CFEntry<T>::kMeansCost(T const & center)
 
 }
 
-#endif
+#endif
diff --git a/bico/core.py b/bico/core.py
index b6f8298..cb472b5 100644
--- a/bico/core.py
+++ b/bico/core.py
@@ -136,7 +136,7 @@ def _compute_coreset(self, fit_coreset: bool = False) -> "BICO":
                 "This BICO instance is not fitted yet. " "Call `fit` or `partial_fit`."
             )
 
-        c_coreset_weights = (ctypes.c_int * self.summary_size)()
+        c_coreset_weights = (ctypes.c_size_t * self.summary_size)()
         c_points = (ctypes.c_double * self.n_features_in_ * self.summary_size)()
 
         _DLL.compute.restype = ctypes.c_int
diff --git a/bico/point/point.h b/bico/point/point.h
index 17fe654..36c005c 100644
--- a/bico/point/point.h
+++ b/bico/point/point.h
@@ -89,12 +89,12 @@ class Point : public WeightedObject
 		return this->coordinates.size();
 	}
 
-	virtual double getWeight() const
+	virtual size_t getWeight() const
 	{
 		return this->weight;
 	}
 
-	virtual void setWeight(double w)
+	virtual void setWeight(size_t w)
 	{
 		this->weight = w;
 	}
@@ -151,4 +151,4 @@ double operator*(Point const & vec1, Point const & vec2);
 
 }
 
-#endif
+#endif

From 7b81d6a22ad56931d45af08dd9d2810c7cc28da9 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:13:43 +0200
Subject: [PATCH 06/19] Change old school cast to static cast

---
 bico/clustering/bico.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index c9e174e..89546c3 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -143,7 +143,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                 int bucket_min = bucket_number;
                 int mins;
 
-                if ((bucket_number < 0) || (bucket_number > (int) outer.buckets[0].size() - 1))
+                if ((bucket_number < 0) || (bucket_number > static_cast<int>(outer.buckets[0].size()) - 1))
                 {
                     // The bucket does not exist (yet)
                     mins = 0;
@@ -156,7 +156,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                     {
                         val = outer.project(element, i);
                         bucket_number = outer.calcBucketNumber(i, val);
-                        if ((bucket_number >= 0) & (bucket_number <= (int) outer.buckets[i].size() - 1))
+                        if ((bucket_number >= 0) & (bucket_number <= static_cast<int>(outer.buckets[i].size()) - 1))
                         {
                             int s = outer.buckets[i][bucket_number].size();
                             if (s < mins)
@@ -185,7 +185,7 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                     // Bucket does not exist => create one
                     outer.allocateBucket(rnd, true);
                 }
-                else if (bucket_number > (int) outer.buckets[rnd].size() - 1)
+                else if (bucket_number > static_cast<int>(outer.buckets[rnd].size()) - 1)
                 {
                     // Bucket does not exist => create one
                     outer.allocateBucket(rnd, false);
@@ -808,9 +808,9 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
                 bucket_number = calcBucketNumber(i, val);
             }
         }
-        else if (bucket_number > (int) buckets[i].size() - 1)
+        else if (bucket_number > static_cast<int>(buckets[i].size()) - 1)
         {
-            while (bucket_number > (int) buckets[i].size() - 1)
+            while (bucket_number > static_cast<int>(buckets[i].size()) - 1)
             {
                 allocateBucket(i, false);
                 bucket_number = calcBucketNumber(i, val);

From 0cc8bd60291328b7c234fe76c7e25884da00b73a Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:25:48 +0200
Subject: [PATCH 07/19] change everything to size_t for consinstency

---
 bico/point/point.h               | 2 +-
 bico/point/pointweightmodifier.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bico/point/point.h b/bico/point/point.h
index 36c005c..db9e025 100644
--- a/bico/point/point.h
+++ b/bico/point/point.h
@@ -137,7 +137,7 @@ class Point : public WeightedObject
 
 private:
 	std::vector<double> coordinates;
-	double weight;
+	size_t weight;
 };
 
 std::ostream& operator<<(std::ostream&, Point const&);
diff --git a/bico/point/pointweightmodifier.h b/bico/point/pointweightmodifier.h
index f224b9c..c17c50d 100644
--- a/bico/point/pointweightmodifier.h
+++ b/bico/point/pointweightmodifier.h
@@ -17,8 +17,8 @@ class PointWeightModifier : public WeightModifier<Point>
 public:
 	virtual PointWeightModifier* clone() const;
 
-	virtual double getWeight(Point&);
-	virtual void setWeight(Point&, double);
+	virtual size_t getWeight(Point&);
+	virtual void setWeight(Point&, size_t);
 };
 
 inline
@@ -28,13 +28,13 @@ PointWeightModifier* PointWeightModifier::clone() const
 }
 
 inline
-double PointWeightModifier::getWeight(Point& p)
+size_t PointWeightModifier::getWeight(Point& p)
 {
     return p.getWeight();
 }
 
 inline
-void PointWeightModifier::setWeight(Point& p, double w)
+void PointWeightModifier::setWeight(Point& p, size_t w)
 {
     p.setWeight(w);
 }

From 773a10d86f86db293bb79f4d4e97f17012bbb20d Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:28:43 +0200
Subject: [PATCH 08/19] Missed declaration

---
 bico/base/weightmodifier.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bico/base/weightmodifier.h b/bico/base/weightmodifier.h
index 721d105..d905236 100644
--- a/bico/base/weightmodifier.h
+++ b/bico/base/weightmodifier.h
@@ -22,10 +22,10 @@ template<typename T> class WeightModifier
 	*/
 	virtual WeightModifier<T>* clone() const = 0;
 
-	virtual double getWeight(T&) = 0;
-	virtual void setWeight(T&, double) = 0;
+	virtual size_t getWeight(T&) = 0;
+	virtual void setWeight(T&, size_t) = 0;
 };
 
 }
 
-#endif
+#endif

From d9abaa900e2be35fffb6de1d832e0454419513df Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:37:13 +0200
Subject: [PATCH 09/19] Change all points back to double

---
 bico/_core.cpp                   | 6 +++---
 bico/base/weightedobject.h       | 4 ++--
 bico/base/weightmodifier.h       | 4 ++--
 bico/core.py                     | 2 +-
 bico/point/point.h               | 6 +++---
 bico/point/pointweightmodifier.h | 8 ++++----
 6 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/bico/_core.cpp b/bico/_core.cpp
index 9df3c32..9264e24 100644
--- a/bico/_core.cpp
+++ b/bico/_core.cpp
@@ -35,7 +35,7 @@ class BicoExternal
     virtual ~BicoExternal();
     void addData(double const *array, uint n);
     void addPoint(double const *array);
-    int compute(size_t *sample_weights,
+    int compute(double *sample_weights,
                 double *points);
 
 private:
@@ -66,7 +66,7 @@ void BicoExternal::addPoint(double const *array)
     *_bico << p;
 }
 
-int BicoExternal::compute(size_t *sample_weights,
+int BicoExternal::compute(double *sample_weights,
                           double *points)
 {
     // Retrieve coreset
@@ -123,7 +123,7 @@ extern "C"
 #if defined(_WIN32) || defined(__CYGWIN__)
     __declspec(dllexport)
 #endif
-    int compute(BicoExternal *bico, size_t *sample_weights,
+    int compute(BicoExternal *bico, double *sample_weights,
                 double *points) { return bico->compute(sample_weights, points); }
 
 #if defined(_WIN32) || defined(__CYGWIN__)
diff --git a/bico/base/weightedobject.h b/bico/base/weightedobject.h
index 90844ca..1fc07da 100644
--- a/bico/base/weightedobject.h
+++ b/bico/base/weightedobject.h
@@ -10,8 +10,8 @@ namespace CluE
 class WeightedObject
 {
 public:
-	virtual size_t getWeight() const = 0;
-	virtual void setWeight(size_t w) = 0;
+	virtual double getWeight() const = 0;
+	virtual void setWeight(double w) = 0;
 };
 
 }
diff --git a/bico/base/weightmodifier.h b/bico/base/weightmodifier.h
index d905236..b9f6610 100644
--- a/bico/base/weightmodifier.h
+++ b/bico/base/weightmodifier.h
@@ -22,8 +22,8 @@ template<typename T> class WeightModifier
 	*/
 	virtual WeightModifier<T>* clone() const = 0;
 
-	virtual size_t getWeight(T&) = 0;
-	virtual void setWeight(T&, size_t) = 0;
+	virtual double getWeight(T&) = 0;
+	virtual void setWeight(T&, double) = 0;
 };
 
 }
diff --git a/bico/core.py b/bico/core.py
index cb472b5..e214561 100644
--- a/bico/core.py
+++ b/bico/core.py
@@ -136,7 +136,7 @@ def _compute_coreset(self, fit_coreset: bool = False) -> "BICO":
                 "This BICO instance is not fitted yet. " "Call `fit` or `partial_fit`."
             )
 
-        c_coreset_weights = (ctypes.c_size_t * self.summary_size)()
+        c_coreset_weights = (ctypes.c_double * self.summary_size)()
         c_points = (ctypes.c_double * self.n_features_in_ * self.summary_size)()
 
         _DLL.compute.restype = ctypes.c_int
diff --git a/bico/point/point.h b/bico/point/point.h
index db9e025..45a6245 100644
--- a/bico/point/point.h
+++ b/bico/point/point.h
@@ -89,12 +89,12 @@ class Point : public WeightedObject
 		return this->coordinates.size();
 	}
 
-	virtual size_t getWeight() const
+	virtual double getWeight() const
 	{
 		return this->weight;
 	}
 
-	virtual void setWeight(size_t w)
+	virtual void setWeight(double w)
 	{
 		this->weight = w;
 	}
@@ -137,7 +137,7 @@ class Point : public WeightedObject
 
 private:
 	std::vector<double> coordinates;
-	size_t weight;
+	double weight;
 };
 
 std::ostream& operator<<(std::ostream&, Point const&);
diff --git a/bico/point/pointweightmodifier.h b/bico/point/pointweightmodifier.h
index c17c50d..f224b9c 100644
--- a/bico/point/pointweightmodifier.h
+++ b/bico/point/pointweightmodifier.h
@@ -17,8 +17,8 @@ class PointWeightModifier : public WeightModifier<Point>
 public:
 	virtual PointWeightModifier* clone() const;
 
-	virtual size_t getWeight(Point&);
-	virtual void setWeight(Point&, size_t);
+	virtual double getWeight(Point&);
+	virtual void setWeight(Point&, double);
 };
 
 inline
@@ -28,13 +28,13 @@ PointWeightModifier* PointWeightModifier::clone() const
 }
 
 inline
-size_t PointWeightModifier::getWeight(Point& p)
+double PointWeightModifier::getWeight(Point& p)
 {
     return p.getWeight();
 }
 
 inline
-void PointWeightModifier::setWeight(Point& p, size_t w)
+void PointWeightModifier::setWeight(Point& p, double w)
 {
     p.setWeight(w);
 }

From 71c92418c5c5e149cd590c2e121fad4102e1a699 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:40:57 +0200
Subject: [PATCH 10/19] Fix some types

---
 bico/_core.cpp         | 8 ++++----
 bico/clustering/bico.h | 4 ++--
 bico/core.py           | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/bico/_core.cpp b/bico/_core.cpp
index 9264e24..b119d33 100644
--- a/bico/_core.cpp
+++ b/bico/_core.cpp
@@ -35,7 +35,7 @@ class BicoExternal
     virtual ~BicoExternal();
     void addData(double const *array, uint n);
     void addPoint(double const *array);
-    int compute(double *sample_weights,
+    size_t compute(double *sample_weights,
                 double *points);
 
 private:
@@ -66,7 +66,7 @@ void BicoExternal::addPoint(double const *array)
     *_bico << p;
 }
 
-int BicoExternal::compute(double *sample_weights,
+size_t BicoExternal::compute(double *sample_weights,
                           double *points)
 {
     // Retrieve coreset
@@ -82,7 +82,7 @@ int BicoExternal::compute(double *sample_weights,
             points[i * _d + j] = sol->proxysets[0][i][j];
         }
     }
-    int m = sol->proxysets[0].size();
+    size_t m = sol->proxysets[0].size();
     delete sol;
 
     return m;
@@ -123,7 +123,7 @@ extern "C"
 #if defined(_WIN32) || defined(__CYGWIN__)
     __declspec(dllexport)
 #endif
-    int compute(BicoExternal *bico, double *sample_weights,
+    size_t compute(BicoExternal *bico, double *sample_weights,
                 double *points) { return bico->compute(sample_weights, points); }
 
 #if defined(_WIN32) || defined(__CYGWIN__)
diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index 89546c3..d49b1ea 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -558,8 +558,8 @@ numOfRebuilds(0)
         // To have the same results, we cache values pair-wise,
         // then return them in swapped order to put them in the same order.
         size_t i = 0;
-        float vals[2] = { };
-        auto getRandomValue = [&]() -> float {
+        double vals[2] = { };
+        auto getRandomValue = [&]() -> double {
             if (! (i % 2)) {
             vals[0] = realDist(rg);
             vals[1] = realDist(rg);
diff --git a/bico/core.py b/bico/core.py
index e214561..5184544 100644
--- a/bico/core.py
+++ b/bico/core.py
@@ -139,7 +139,7 @@ def _compute_coreset(self, fit_coreset: bool = False) -> "BICO":
         c_coreset_weights = (ctypes.c_double * self.summary_size)()
         c_points = (ctypes.c_double * self.n_features_in_ * self.summary_size)()
 
-        _DLL.compute.restype = ctypes.c_int
+        _DLL.compute.restype = ctypes.c_size_t
         n_found_points = _DLL.compute(self.bico_obj_, c_coreset_weights, c_points)
 
         self._coreset_weights: np.ndarray = np.ctypeslib.as_array(c_coreset_weights)[

From 255c5caf5f5848fab0ddac2ab1c644567ce2f455 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:46:53 +0200
Subject: [PATCH 11/19] Add some static casts

---
 bico/clustering/bico.h    | 8 ++++----
 bico/clustering/cfentry.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index d49b1ea..9d647c2 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -798,14 +798,14 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
     for (size_t i = 0; i < L; i++)
     {
         double val = project(iteratorElement->first.representative, i);
-        int bucket_number = calcBucketNumber(i, val);
+        int bucket_number = calcBucketNumber(static_cast<int>(i), val);
 
         if (bucket_number < 0)
         {
             while (bucket_number < 0)
             {
-                allocateBucket(i, true);
-                bucket_number = calcBucketNumber(i, val);
+                allocateBucket(static_cast<int>(i), true);
+                bucket_number = calcBucketNumber(static_cast<int>(i), val);
             }
         }
         else if (bucket_number > static_cast<int>(buckets[i].size()) - 1)
@@ -813,7 +813,7 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
             while (bucket_number > static_cast<int>(buckets[i].size()) - 1)
             {
                 allocateBucket(i, false);
-                bucket_number = calcBucketNumber(i, val);
+                bucket_number = calcBucketNumber(static_cast<int>(i), val);
             }
         }
         buckets[i][bucket_number].push_back(iteratorElement);
diff --git a/bico/clustering/cfentry.h b/bico/clustering/cfentry.h
index d75a43d..0c0bf1d 100644
--- a/bico/clustering/cfentry.h
+++ b/bico/clustering/cfentry.h
@@ -108,7 +108,7 @@ template<typename T> void CFEntry<T>::insert(T const & x)
 		WeightedObject const * wm = static_cast<WeightedObject const *>(&x);
 		weight = wm->getWeight();
 	}
-	number += weight;
+	number += static_cast<size_t>(weight);
 	LS += weight * x;
 	SS += weight * (x*x);
 }
@@ -121,7 +121,7 @@ template<typename T> void CFEntry<T>::remove(T const & x)
 		WeightedObject const * wm = static_cast<WeightedObject const *>(&x);
 		weight = wm->getWeight();
 	}
-	number -= weight;
+	number -= static_cast<size_t>(weight);
 	LS -= weight * x;
 	SS -= weight * (x*x);
 }

From 12c09a0aae3d0f69c172ef1c8c7eb3a3dda6892e Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:53:04 +0200
Subject: [PATCH 12/19] Many more static conversions

---
 bico/clustering/bico.h             | 16 ++++++++--------
 bico/datastructure/proxysolution.h |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index 9d647c2..d6de1a9 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -154,8 +154,8 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                     mins = outer.buckets[mini][bucket_min].size();
                     for (size_t i = 1; i < outer.L; i++)
                     {
-                        val = outer.project(element, i);
-                        bucket_number = outer.calcBucketNumber(i, val);
+                        val = outer.project(element, static_cast<int>(i));
+                        bucket_number = outer.calcBucketNumber(static_cast<int>(i), val);
                         if ((bucket_number >= 0) & (bucket_number <= static_cast<int>(outer.buckets[i].size()) - 1))
                         {
                             int s = outer.buckets[i][bucket_number].size();
@@ -163,14 +163,14 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                             {
                                 mins = s;
                                 bucket_min = bucket_number;
-                                mini = i;
+                                mini = static_cast<int>(i);
                             }
                         }
                         else
                         {
                             mins = 0;
                             bucket_min = bucket_number;
-                            mini = i;
+                            mini = static_cast<int>(i);
                             break;
                         }
                     }
@@ -702,7 +702,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
         // Update bucket configuration
         for (size_t i = 0; i < L; i++)
         {
-            double val = std::abs(project(element, i));
+            double val = std::abs(project(element, static_cast<int>(i)));
             if (val > maxVal[i] || maxVal[i] == -1)
             {
                 maxVal[i] = val;
@@ -746,7 +746,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
             {
                 if(projection_buffer[i].first >= upperEnd)
                 {
-                    upperIndex = i;
+                    upperIndex = static_cast<int>(i);
 
                     for(int j = lowerIndex; j < upperIndex; ++j)
                     {
@@ -761,7 +761,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
                         }
                     }
 
-                    lowerIndex = i;
+                    lowerIndex = static_cast<int>(i);
                     lowerEnd = projection_buffer[i].first;
                     upperEnd = lowerEnd + minProjRealDist;
                 }
@@ -812,7 +812,7 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
         {
             while (bucket_number > static_cast<int>(buckets[i].size()) - 1)
             {
-                allocateBucket(i, false);
+                allocateBucket(static_cast<int>(i), false);
                 bucket_number = calcBucketNumber(static_cast<int>(i), val);
             }
         }
diff --git a/bico/datastructure/proxysolution.h b/bico/datastructure/proxysolution.h
index 9d745e6..0615524 100644
--- a/bico/datastructure/proxysolution.h
+++ b/bico/datastructure/proxysolution.h
@@ -27,8 +27,8 @@ template<typename T> struct ProxySolution : public SolutionProvider, public Prox
 	}
 
 	virtual double computationtime() const;
-	virtual unsigned int number_of_solutions() const;
-	virtual unsigned int size_of_solution(unsigned int) const;
+	virtual size_t number_of_solutions() const;
+	virtual size_t size_of_solution(unsigned int) const;
 
 	virtual T proxy(unsigned int n, unsigned int c) const;
 	virtual std::vector<T> proxies(unsigned int n) const;
@@ -46,12 +46,12 @@ template<typename T> double ProxySolution<T>::computationtime() const
 	return seconds;
 }
 
-template<typename T> unsigned int ProxySolution<T>::number_of_solutions() const
+template<typename T> size_t ProxySolution<T>::number_of_solutions() const
 {
 	return this->proxysets.size();
 }
 
-template<typename T> unsigned int ProxySolution<T>::size_of_solution(unsigned int i) const
+template<typename T> size_t ProxySolution<T>::size_of_solution(unsigned int i) const
 {
 	if (i<this->proxysets.size())
 		return this->proxysets[i].size();

From bf319758dfe19f85086941f31cbaa170b8f5294d Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 13:56:27 +0200
Subject: [PATCH 13/19] Forgotten one definition

---
 bico/base/proxyprovider.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bico/base/proxyprovider.h b/bico/base/proxyprovider.h
index 5e8411d..32d5151 100644
--- a/bico/base/proxyprovider.h
+++ b/bico/base/proxyprovider.h
@@ -24,7 +24,7 @@ template<typename T> class ProxyProvider {
 	* number of computed clusters, proxies (e.g. cluster centers) or the size of a coreset.
 	* The sizes can be retrieved by a call to size_of_solution().
 	*/
-	virtual unsigned int number_of_solutions() const = 0;
+	virtual size_t number_of_solutions() const = 0;
 
 	/**
 	* @brief returns the size of a particular solution
@@ -32,7 +32,7 @@ template<typename T> class ProxyProvider {
 	* @param index number between 0 and @ref number_of_solutions()-1
 	* @return the size for the requested clustering
 	*/
-	virtual unsigned int size_of_solution(unsigned int index) const = 0;
+	virtual size_t size_of_solution(unsigned int index) const = 0;
 
 	/**
 	* @brief returns the proxy for the specified clustering and cluster

From 1ee52aa5ea50953175d9abac36926b1a0a10dc3d Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:00:49 +0200
Subject: [PATCH 14/19] More static casts

---
 bico/clustering/bico.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index d6de1a9..a523173 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -151,14 +151,14 @@ template<typename T> class Bico : public StreamingAlgorithm<T>
                 else
                 {
                     // Search for the projection with smallest bucket size
-                    mins = outer.buckets[mini][bucket_min].size();
+                    mins = static_cast<int>(outer.buckets[mini][bucket_min].size());
                     for (size_t i = 1; i < outer.L; i++)
                     {
                         val = outer.project(element, static_cast<int>(i));
                         bucket_number = outer.calcBucketNumber(static_cast<int>(i), val);
                         if ((bucket_number >= 0) & (bucket_number <= static_cast<int>(outer.buckets[i].size()) - 1))
                         {
-                            int s = outer.buckets[i][bucket_number].size();
+                            int s = static_cast<int>(outer.buckets[i][bucket_number].size());
                             if (s < mins)
                             {
                                 mins = s;
@@ -689,7 +689,7 @@ template<typename T> void Bico<T>::computeTraverse(BicoNode* node, ProxySolution
     for (auto it = node->begin(); it != node->end(); ++it)
     {
         T point(it->first.cog());
-        weightModifier->setWeight(point, it->first.number);
+        weightModifier->setWeight(point, static_cast<double>(it->first.number));
         solution->proxysets[0].push_back(point);
         computeTraverse(it->second, solution);
     }
@@ -797,7 +797,7 @@ template<typename T> void Bico<T>::insertIntoNN(typename BicoNode::FeatureList::
 {
     for (size_t i = 0; i < L; i++)
     {
-        double val = project(iteratorElement->first.representative, i);
+        double val = project(iteratorElement->first.representative, static_cast<int>(i));
         int bucket_number = calcBucketNumber(static_cast<int>(i), val);
 
         if (bucket_number < 0)

From dcfabdfacdae1432f9c34cd6fbe36511e6f03a58 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:19:07 +0200
Subject: [PATCH 15/19] Remove last warnings2

---
 bico/clustering/bico.h   | 4 ++--
 bico/misc/randomness.cpp | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bico/clustering/bico.h b/bico/clustering/bico.h
index a523173..e56158c 100644
--- a/bico/clustering/bico.h
+++ b/bico/clustering/bico.h
@@ -613,7 +613,7 @@ template<typename T> void Bico<T>::initializeNN()
         }
         else
         {
-            bucket_radius[i] = (long long int) ceil(sqrt(getR(1)));
+            bucket_radius[i] = (double) ceil(sqrt(getR(1)));
             Size = (int) ceil((borders[i].second - borders[i].first) / (double) bucket_radius[i]);
             if(Size < 0 || Size > maxBuckets)
             {
@@ -771,7 +771,7 @@ template<typename T> Bico<T>& Bico<T>::operator<<(T const & element)
             optEst = 16.0 * minDist;
             //std::cout << "minDist = " << minDist << std::endl;
             //std::cout << "optEst  = " << minDist << std::endl;
-            long long int radius = (long long int) ceil(sqrt(getR(1)));
+            double radius = (double) ceil(sqrt(getR(1)));
             borders.resize(L);
             for (size_t i = 0; i < L; i++)
             {
diff --git a/bico/misc/randomness.cpp b/bico/misc/randomness.cpp
index 15983e7..dc18ae9 100644
--- a/bico/misc/randomness.cpp
+++ b/bico/misc/randomness.cpp
@@ -2,4 +2,4 @@
 
 using namespace CluE;
 
-std::mt19937 Randomness::mt19937Generator(time(0));
+std::mt19937 Randomness::mt19937Generator(static_cast<unsigned int>(time(0)));

From aa70f472fc64a883d0316f1439b89a9922cb70c5 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:33:12 +0200
Subject: [PATCH 16/19] Add git hasH

---
 .github/workflows/gitlab.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/gitlab.yml b/.github/workflows/gitlab.yml
index ce5703c..36a20a5 100644
--- a/.github/workflows/gitlab.yml
+++ b/.github/workflows/gitlab.yml
@@ -28,4 +28,4 @@ jobs:
         access_token: ${{ secrets.DEPLOY_ACCESS_TOKEN }}
         id: '3102'
         ref: 'main'
-        variables: '{"PROJECT":"bico"}'
+        variables: ${{ format('{"PROJECT":"bico", "GIT_HASH": "{0}"}', $GITHUB_SHA)}}

From 65f48f4172c10d593a744c67a5d5e1773d10e6b2 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:41:34 +0200
Subject: [PATCH 17/19] Fix workflow

---
 .github/workflows/gitlab.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/gitlab.yml b/.github/workflows/gitlab.yml
index 36a20a5..f4d7b0c 100644
--- a/.github/workflows/gitlab.yml
+++ b/.github/workflows/gitlab.yml
@@ -28,4 +28,4 @@ jobs:
         access_token: ${{ secrets.DEPLOY_ACCESS_TOKEN }}
         id: '3102'
         ref: 'main'
-        variables: ${{ format('{"PROJECT":"bico", "GIT_HASH": "{0}"}', $GITHUB_SHA)}}
+        variables: ${{ toJson({ 'PROJECT': 'bico', 'GIT_HASH': github.sha }) }}

From 47511760d68703e4f2925d15abe232d50e437c1e Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:43:20 +0200
Subject: [PATCH 18/19] Fix workflow

---
 .github/workflows/gitlab.yml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/gitlab.yml b/.github/workflows/gitlab.yml
index f4d7b0c..18dd0e7 100644
--- a/.github/workflows/gitlab.yml
+++ b/.github/workflows/gitlab.yml
@@ -28,4 +28,8 @@ jobs:
         access_token: ${{ secrets.DEPLOY_ACCESS_TOKEN }}
         id: '3102'
         ref: 'main'
-        variables: ${{ toJson({ 'PROJECT': 'bico', 'GIT_HASH': github.sha }) }}
+        variables: |
+          {
+            "PROJECT": "bico",
+            "GIT_HASH": "${{ github.sha }}"
+          }

From e057b9bb317961ddb432b225aaabdfa6b37a7f90 Mon Sep 17 00:00:00 2001
From: Giulia Baldini <giulia.baldini@hhu.de>
Date: Wed, 5 Jun 2024 14:49:55 +0200
Subject: [PATCH 19/19] Syntax of git hash that works for pull and push

---
 .github/workflows/gitlab.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/gitlab.yml b/.github/workflows/gitlab.yml
index 18dd0e7..56b0eef 100644
--- a/.github/workflows/gitlab.yml
+++ b/.github/workflows/gitlab.yml
@@ -31,5 +31,5 @@ jobs:
         variables: |
           {
             "PROJECT": "bico",
-            "GIT_HASH": "${{ github.sha }}"
+            "GIT_HASH": "${{ github.event.pull_request.head.sha || github.sha }}"
           }