Skip to content
This repository has been archived by the owner on Feb 12, 2020. It is now read-only.

logged in already after deactivating alpheios #433

Closed
monzug opened this issue Apr 12, 2019 · 7 comments
Closed

logged in already after deactivating alpheios #433

monzug opened this issue Apr 12, 2019 · 7 comments
Labels
bug Something isn't working verified passed qa

Comments

@monzug
Copy link

monzug commented Apr 12, 2019

Both Chrome and Firefox 3.0.0.25
if I click on Deactivate Alpheios, all icons are closed (this was an issue on GitHub) but when I reactivate Alpheios, panel is open with the blank page, Wordlist and login are still active from previous session. Shouldn't the command deactivate Alpheios close all actions including wordlist and logout?

@balmas balmas added bug Something isn't working and removed discussion labels Apr 12, 2019
@balmas
Copy link
Member

balmas commented Apr 12, 2019

yes i think it should.

@balmas
Copy link
Member

balmas commented Apr 24, 2019

actually, I'm not sure if deactivating Alpheios should log you out. I just implemented a fix for #427 which will fixes the problem of not retaining the session across page loads (and will also allow the session to be used across tabs). The user login has an expiration which is enforced so the session does not last indefinitely (although we could also refresh the session for the user if we want -- see alpheios-project/webextension#213).

I am leaning towards keeping the session active until it times out, the user explicitly logs out, or they close their browser. What do you think @monzug ? what is the benefit of logging out upon deactivation?

@balmas balmas added the question Further information is requested label Apr 24, 2019
@monzug
Copy link
Author

monzug commented Apr 25, 2019

I have seen this issue few times today (build 3.0.0.29), always doing the following:

  1. logged out
  2. deactivating alpheios, activating alpheios
  3. the wordlist is the last username's wordlist
    and I see this
    logged-out-uhm
    when I click on Logged out button, then the Log in button is generated and then username no longer shows up.

if we have multiple users on same computer, I want to be sure to logged out completely. that's why I am also deactivating Alpheios as an extra step. there is something not quite right here.

@balmas balmas closed this as completed May 8, 2019
@balmas balmas assigned balmas and unassigned balmas and monzug May 8, 2019
@balmas balmas reopened this May 8, 2019
@balmas
Copy link
Member

balmas commented May 8, 2019

I think the weird behavior on logging out was fixed, so back to this comment:

I am leaning towards keeping the session active until it times out, the user explicitly logs out, or they close their browser. What do you think @monzug ? what is the benefit of logging out upon deactivation?

@balmas balmas assigned monzug and unassigned balmas May 8, 2019
@monzug monzug assigned balmas and unassigned monzug May 12, 2019
@monzug
Copy link
Author

monzug commented May 12, 2019

Yesterday I installed new build and I found myself already logged in. Note that before uninstalling the tools, I do clear data and history. I don't close the browser though, could it be session cookie?
Usually when I log out and then I log in again, I am prompt to enter id/psw. Sometimes, I get in without prompting for id/psw (session cookie?)

@balmas
Copy link
Member

balmas commented May 13, 2019

Yes, It's a session cookie added by the Auth0 application.

@monzug
Copy link
Author

monzug commented May 13, 2019

ok so we can close this one. Thanks

@monzug monzug closed this as completed May 13, 2019
@monzug monzug added verified passed qa and removed question Further information is requested labels May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified passed qa
Projects
None yet
Development

No branches or pull requests

2 participants