Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move components into regular dependencies #72

Open
balmas opened this issue Jul 17, 2019 · 0 comments
Open

move components into regular dependencies #72

balmas opened this issue Jul 17, 2019 · 0 comments

Comments

@balmas
Copy link
Member

balmas commented Jul 17, 2019

I'm not sure we need this because embed-lib has its own dependency on components and components will get installed through it anyway

alpheiso-components is a dev dependency but it will still gets installed with npm install. But I'm wondering if it's worth moving components into "regular" dependencies inside the embed-lib package because we're linking it dynamically now and it is required for the embed-lib execution. What do you think?

Originally posted by @kirlat in alpheios-project/alpheios_nemo_ui#218
@balmas balmas assigned balmas and unassigned kirlat Jul 30, 2019
@balmas balmas removed their assignment Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balmas @kirlat