From 6a3143f31de3a42d5ca142d053a4f8a732914def Mon Sep 17 00:00:00 2001 From: Yoan Blanc Date: Wed, 16 Aug 2017 10:51:00 -0400 Subject: [PATCH] ETag are expecting to be enclosed in quotes. Signed-off-by: Yoan Blanc --- etag.go | 2 +- etag_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/etag.go b/etag.go index 5557035..96a84c9 100644 --- a/etag.go +++ b/etag.go @@ -12,7 +12,7 @@ func getHash(str string) string { // Generate an Etag for given sring. Allows specifying whether to generate weak // Etag or not as second parameter func Generate(str string, weak bool) string { - tag := fmt.Sprintf("%d-%s", len(str), getHash(str)) + tag := fmt.Sprintf("\"%d-%s\"", len(str), getHash(str)) if weak { tag = "W/" + tag } diff --git a/etag_test.go b/etag_test.go index 9de7755..849480e 100644 --- a/etag_test.go +++ b/etag_test.go @@ -14,7 +14,7 @@ func TestNotWeekEtag(t *testing.T) {

test page html

` - expectedOut := fmt.Sprintf("%d-%s", len(inputStr), getHash(inputStr)) + expectedOut := fmt.Sprintf("\"%d-%s\"", len(inputStr), getHash(inputStr)) generatedOut := Generate(inputStr, false) if generatedOut != expectedOut { t.Fatalf("Incorrect Etag generated") @@ -30,7 +30,7 @@ func TestWeekEtag(t *testing.T) {

test page html

` - expectedOut := fmt.Sprintf("W/%d-%s", len(inputStr), getHash(inputStr)) + expectedOut := fmt.Sprintf("W/\"%d-%s\"", len(inputStr), getHash(inputStr)) generatedOut := Generate(inputStr, true) if generatedOut != expectedOut { t.Fatalf("Incorrect Etag generated")