Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IonElementLoaderOptions #19

Closed
dlurton opened this issue Jun 11, 2020 · 1 comment
Closed

Create IonElementLoaderOptions #19

dlurton opened this issue Jun 11, 2020 · 1 comment

Comments

@dlurton
Copy link
Contributor

dlurton commented Jun 11, 2020

This should be passed as an argument to an overload of createIonElementLoader and to the functions created as part of #18. IonElementLoaderImpl should use this instead of fields to store its options.

It should look something like:

data class IonElementLoaderOptions(
    val includeLocations: Boolean = false,

    val metaLoaderRegistry: Map<String, IonElementTransformer<Meta>>
)

metaLoaderRegistry may not be needed in the initial cut, but should at least be added as part of #20.

@dlurton
Copy link
Contributor Author

dlurton commented Jun 25, 2020

Was implemented in this commit: 02b98f8

@dlurton dlurton closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant