Do not run cmake-package-check on Windows under bash #941
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
GiulioRomualdi and
S-Dafarra
as code owners
|
The CI is failing due to #933, unrelated to the PR. |
GiulioRomualdi
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake-package-checkon Windows usesNinja, that needs to be run undercmd.exeas the activation scripts of Visual Studio do not run on bash. I have no idea how it worked before. I am not a big fan of all the duplication between Windows and Linux/macOS, but that is already how the CI job is implemented.Fix #940 .